Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15.1 RC: 'Multi URL Picker' not updating value with Block Level Variations #17700

Closed
JBoye opened this issue Dec 2, 2024 · 10 comments
Closed

Comments

@JBoye
Copy link

JBoye commented Dec 2, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

V15.1 RC

Bug summary

I cannot get a Multi URL Picker to work in combination with Block Level Variations.

It looks OK in the backoffice, but the value outputted in Delivery API is incorrect

Specifics

Backoffice

Content Delivery API

Steps to reproduce

Website.zip

Run the website, go to

https://localhost:44313/umbraco/delivery/api/v2/content/item/en

https://localhost:44313/umbraco/delivery/api/v2/content/item/da

Expected result / actual result

The value of CTA should be vary between danish and english, like it does outside of the block list

@JBoye JBoye added the type/bug label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Hi there @JBoye!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Hi @JBoye , I couldn't reproduce as you did. Could you provide more details
image
image

@NguyenThuyLan NguyenThuyLan added the state/needs-more-info We don't have enough information to give a good reply label Dec 4, 2024
@JBoye
Copy link
Author

JBoye commented Dec 4, 2024

Not sure how you set it up, but i can replicate it in a clean 15.0.0 or 15.1 RC by just importing this with uSync

usync-export.zip

@nielslyngsoe
Copy link
Member

Hi @JBoye really good and interesting case.

I would need you to describe the specific setup. Down to the variant configuration of your Element Type and the Properties of it — it will be good for you to verify that the setup is correct for your case and in this way we can verify if this is the intended experience or not.

Also notice this could be caused by uSync, and then it is a bit hard for us to do something about it, so you could also try to migrate data with another tool, like Umbraco Deploy: https://docs.umbraco.com/umbraco-deploy/deployment-workflow/import-export

Also notice if it turns out to be uSync related, then you can report it there:
https://github.com/KevinJump/uSync/issues

Thanks for your effort :-)

@JBoye
Copy link
Author

JBoye commented Dec 6, 2024

Thanks @nielslyngsoe

I had the issue in my dev site, and then recreated it in a clean install

The uSync files was mostly just to share the exact setup for others to reproduce the errors.

I will try to recreate it again, and share the specific steps

@JBoye
Copy link
Author

JBoye commented Dec 6, 2024

dotnet new install Umbraco.Templates::15.1.0-rc
dotnet new umbraco --use-delivery-api

Use default sqlite db

Create "Element" doctype

  • enable "Vary by culture"
  • enable "Element type"
  • add property "CTA" Multi URL Picker (use existing datatype)
    • enable "Vary by culture"
  • Save "Element"

Create "Main" doctype

  • enable "Vary by culture"
  • enable "Allow at root"
  • Add property "Content"
    • Create new Block List Configuration
    • Add Element as available Block

Create Language "da-DK"

Create a "Main" Page

Open split view

Under english:

Under danish

Add domains

  • /en English
  • /da Danish

Save and publish

Compare

  • /umbraco/delivery/api/v2/content/item/en
  • /umbraco/delivery/api/v2/content/item/da

For me, both request are showing the link to umbraco.com instead of .dk

If i add the CTA property directly on the Main doc type, the danish version links correctly to .dk

@NguyenThuyLan
Copy link
Contributor

NguyenThuyLan commented Dec 10, 2024

Hi @JBoye , thank you for sharing the details of the reproduction steps.
I was able to reproduce it.
The reason seems that you only enable the "vary by culture" of properties inside the Blocklist instead of enabling "Vary by culture" of the BlockList.
But this still be a bug 🐞

@kjac
Copy link
Contributor

kjac commented Jan 20, 2025

I can reproduce this one in the V15.latest.

While it is most apparent in the Delivery API output, the issue is actually related to Elements level caching for property values. As such, I can reproduce the issue with regular Razor rendering too - albeit using a Content Picker instead of the Multi URL Picker, because it applies the Elements level caching for "regular" Razor renderings.

I'll dig into it as soon as I can.

@kjac
Copy link
Contributor

kjac commented Jan 23, 2025

PR in #18080 to fix 👍

@kjac
Copy link
Contributor

kjac commented Jan 29, 2025

Fixed by #18080 for V15.2 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants