Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

our-svg default cache can't be overridden #57

Open
drpeck opened this issue Apr 28, 2023 · 1 comment
Open

our-svg default cache can't be overridden #57

drpeck opened this issue Apr 28, 2023 · 1 comment

Comments

@drpeck
Copy link
Contributor

drpeck commented Apr 28, 2023

If you set the SVG cache to be on in appsettings.config, and then wish to disable it on a specific tag instance then it is not possible.

Ideally InlineSvgTagHelper.Cache (https://github.com/umbraco-community/Our-Umbraco-TagHelpers/blob/main/Our.Umbraco.TagHelpers/InlineSvgTagHelper.cs#L72) would be nullable, and it would respect a true/false value before considering the appsettings.config value.
@warrenbuckley
Copy link
Member

Hiya @drpeck
Would you be interested in doing the fix in a PR and perhaps update the unit test to ensure this scenario & the other issue with our-svg in #58 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drpeck @warrenbuckley