Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey report regression #3268

Open
Maxime-J opened this issue Feb 24, 2025 · 2 comments
Open

Journey report regression #3268

Maxime-J opened this issue Feb 24, 2025 · 2 comments

Comments

@Maxime-J
Copy link
Contributor

Describe the Bug

Starting from 2.16, if you create a journey report without specifying start and end steps, the request doesn't succeed: Zod is rejecting it.

It can be temporarily bypassed by filling and erasing the steps fields so that the request includes empty strings.

Database

MySQL

Relevant log output

{
    "error": {
        "issues": [
            {
                "code": "invalid_type",
                "expected": "string",
                "received": "undefined",
                "path": [
                    "startStep"
                ],
                "message": "Required"
            },
            {
                "code": "invalid_type",
                "expected": "string",
                "received": "undefined",
                "path": [
                    "endStep"
                ],
                "message": "Required"
            }
        ],
        "name": "ZodError",
        [...]
        "errors": [
            {
                "code": "invalid_type",
                "expected": "string",
                "received": "undefined",
                "path": [
                    "startStep"
                ],
                "message": "Required"
            },
            {
                "code": "invalid_type",
                "expected": "string",
                "received": "undefined",
                "path": [
                    "endStep"
                ],
                "message": "Required"
            }
        ]
    }
}

Which Umami version are you using? (if relevant)

2.16.1

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

@mikecao
Copy link
Collaborator

mikecao commented Feb 26, 2025

I think the bug is the start and end steps weren't required before. What is the expected output without defined steps?

@Maxime-J
Copy link
Contributor Author

Exactly, and all paths are shown when the steps are not defined, like in the release notes
https://github.com/umami-software/umami/releases/tag/v2.12.0

Empty strings are now needed to match the previous behaviour, which breaks the reports without defined steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants