Skip to content

Conversation

@Semyon-Baykov
Copy link

Overview: What does this pull request change?

This PR resolves Issue #3, which addresses unnecessary inheritance from VGroup in several Mobjects. I replaced all instances of VGroup inheritance with VMobject to avoid unexpected behavior with operators and grouping functionality, as stated in the issue.

Motivation and Explanation: Why and how do your changes improve the library?

The original use of VGroup was unnecessary and could cause issues with object grouping behaviors. I reviewed the VGroup methods from vectorized_mobject.py and verified that none of the affected Mobjects required VGroup's grouping-specific behaviors.

Further Information and Comments

I'm in the SWE class, so please let me know if something is incorrect. This is my first ever OSC contribution!

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added code segments are adequately covered by tests
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant