-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new page that links to Discord Server #437
Conversation
Nice change! However, I think it looks a bit out of place on the nav bar tbh. I think it might need some more discussion. Regardless, good job! |
@nathanzzhang @jakobreinwald @maggieelli @jamesmwu @EinarBalan I still agree with the original issue that raised that we should have a link to our discord available to people who are interested without them having to click around to find it. Other issues that arise are that we might get more bots/spammers though. |
I think that having the text on the nav bar as "Discord" is fine-- I feel like Contact Us implies email usually. And while it's not typical, I think having the link directly on the nav bar is fine since it's our club's main way of communication and up to date information. |
I kind of agree with Katelyn that "Discord" is a bit odd to have on our nav bar since it feels out of place compared to the other pages, but I get why we want to have the Discord link more accessible. Personally I think at least changing the text to "Join Us" or something would be much better, but also I think it still is a bit odd to have it on the nav bar since it's not directing to a page, but rather a link. Do we think the glowy gradient link on our home page under our banner that says "Want to learn more about our internship program..." is necessary to have right now? If not, we could replace that button to something like "Join our Discord to get up-to-date information about our events!" or something |
I actually like the idea of replacing the glowy gradient with a link to our discord with some relevant text instead of adding it to the navbar. Although with that change, the button about half a page down "Join the ACM Hack Discord" is a bit irrelevant LOL |
Guys lets just nix the discord link in the nav bar entirely and just create a page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the current link as it is and instead change the "Apply" button to say "Discord" and link to the Discord?
Changes
Added a new page on the ButtonBar. The "Discord" button links directly to the Discord permalink.
Type of change
New feature
Related Issues
close #383