Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timezone behavior consistent in dev mode and static build #123

Closed
GalenWong opened this issue Nov 5, 2020 · 1 comment
Closed

Make timezone behavior consistent in dev mode and static build #123

GalenWong opened this issue Nov 5, 2020 · 1 comment
Labels
backlog Not a priority task, but needs to be done

Comments

@GalenWong
Copy link
Contributor

Right now, the dev mode is executed locally. Date object generated in data/events.js is created with local timezone. In netlify or github action build, timezone is always PT. We can change the getDateTime to always use PT.
@TimothyGu
Copy link
Contributor

I think we should just set the timezone to Pacific on local builds too, which should be as easy as setting the TZ=America/Los_Angeles environment variable in package.json. If we care about supporting Windows, we could use cross-env.

@jamesmwu jamesmwu added the backlog Not a priority task, but needs to be done label May 18, 2024
@jamesmwu jamesmwu closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Not a priority task, but needs to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TimothyGu @GalenWong @jamesmwu