Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic bug in removing friends #413

Open
omarelkashef opened this issue Dec 5, 2023 · 0 comments
Open

Fix logic bug in removing friends #413

omarelkashef opened this issue Dec 5, 2023 · 0 comments
Labels
bug Something isn't working x/user-profiles-friending

Comments

@omarelkashef
Copy link
Member

Currently, when a friend is removed, the corresponding friend invitation is deleted from the database but the notification assigned to that invitation is only marked as deleted and a user can retrieve it. However, it will not have an assigned "actor" because the FriendInvitation is deleted. One solution is that FriendInvitation is be treated as and is only marked as deleted and can be retrieved with the notification. Now, we only work around this and display a message that this notification is invalid.

@omarelkashef omarelkashef converted this from a draft issue Dec 5, 2023
@omarelkashef omarelkashef added bug Something isn't working x/user-profiles-friending labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x/user-profiles-friending
Projects
Status: Backlog
Development

No branches or pull requests

1 participant