#2013 Made minimal changes to locked package versions to support Node 18. Updated Node version requirements in relevant package.json files, fixed new undefined error message in tests.

Author: FrenjaminBanklin

.github/workflows/tests.yml

@@ -5,7 +5,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x]
+        node-version: [18.x]
     steps:
     - name: Checkout code
       uses: actions/checkout@v2
@@ -19,10 +19,10 @@ jobs:
     # should help to speed up yarn install and be safe
     # across changes to the repo and platforms
     - name: Cache Yarn Deps
-      uses: c-hive/gha-yarn-cache@v1      
+      uses: c-hive/gha-yarn-cache@v1
 
     - run: echo "github.ref = ${{ github.ref }}"
-      
+
     # frozen lockfile should make the cache more effective
     # and our tests more predictable
     - run: yarn install --frozen-lockfile
@@ -35,7 +35,7 @@ jobs:
     # will fail the PRs that need prettier run on them
     - name: Does Prettier Need to Be Run
       run: git --no-pager diff --exit-code -- .
-    
+
     - run: yarn test:ci
 
   build_docker_images:
@@ -83,7 +83,7 @@ jobs:
     - name: NPM - Test, Build, Deploy
       uses: actions/setup-node@v1
       with:
-        node-version: 14
+        node-version: 18
         registry-url: https://registry.npmjs.org/
 
     - name: Cache Yarn Deps

docker/dockerfiles/obojobo-node-debian.Dockerfile

@@ -1,7 +1,7 @@
 # =====================================================================================================
 # Base stage used for  build and final stages
 # =====================================================================================================
-FROM node:14.16.0-alpine AS base_stage
+FROM node:18.16.0-alpine AS base_stage
 
 # ======== PUT NEW NODE BIN DIR IN PATH
 RUN npm config set prefix '/home/node/.npm-global'

package.json

@@ -103,6 +103,6 @@
 	],
 	"engines": {
 		"yarn": "^1.15.2",
-		"node": "^14.16.0"
+		"node": "^18.16.0"
 	}
 }

packages/app/obojobo-document-engine/package.json

@@ -4,7 +4,7 @@
 	"license": "AGPL-3.0-only",
 	"description": "",
 	"engines": {
-		"node": "^14.16.0"
+		"node": "^18.16.0"
 	},
 	"main": "index.js",
 	"scripts": {

packages/app/obojobo-express/__tests__/routes/api/visits.test.js

@@ -368,7 +368,7 @@ describe('api visits route', () => {
 				expect(response.body.value).toHaveProperty('type', 'reject')
 				expect(response.body.value).toHaveProperty(
 					'message',
-					"Cannot read property 'lis_outcome_service_url' of undefined"
+					"Cannot read properties of undefined (reading 'lis_outcome_service_url')"
 				)
 			})
 	})

packages/app/obojobo-express/package.json

@@ -28,7 +28,7 @@
 		"precommit": "lint-staged"
 	},
 	"engines": {
-		"node": "^14.16.0"
+		"node": "^18.16.0"
 	},
 	"lint-staged": {
 		"**/*.scss": [

packages/app/obojobo-module-selector/package.json

@@ -15,7 +15,7 @@
 		"precommit": "lint-staged"
 	},
 	"engines": {
-		"node": "^14.16.0"
+		"node": "^18.16.0"
 	},
 	"lint-staged": {
 		"**/*.scss": [

packages/app/obojobo-repository/package.json

@@ -15,7 +15,7 @@
 		"precommit": "lint-staged"
 	},
 	"engines": {
-		"node": "^14.16.0"
+		"node": "^18.16.0"
 	},
 	"lint-staged": {
 		"**/*.scss": [