Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support for multipart uploads to non-AWS S3 endpoints #1115

Merged
merged 0 commits into from
Apr 3, 2024
Merged

Update support for multipart uploads to non-AWS S3 endpoints #1115

merged 0 commits into from
Apr 3, 2024

Conversation

lbeckman314
Copy link
Contributor

New Features

  • Updates support for retrieving correct endpoints and credentials for non-AWS bucket parameters.

Breaking Changes

  • None

Bug Fixes

  • Passes bucket parameter if present to fence/blueprints/data/indexd.py:init_multipart_upload function.

Improvements

Dependency updates

  • None

Deployment changes

  • None

@lbeckman314
Copy link
Contributor Author

lbeckman314 commented Jan 22, 2024 •
edited
Loading

Converting to draft until unit tests in PR #1127 are running. PR #1115 should take precedence if any merge conflicts arise.

@lbeckman314 lbeckman314 mentioned this pull request Jan 22, 2024
Merged
1 task
@lbeckman314 lbeckman314 marked this pull request as draft January 22, 2024 18:56
BinamB
BinamB reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@BinamB BinamB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was comparing it to the PR I have, could you resolve the conflicts? Everything else looks fine.

@BinamB BinamB merged commit 0e2c5ec into uc-cdis:feat/multi_part_bucket_param Apr 3, 2024
1 of 2 checks passed
@lbeckman314 lbeckman314 deleted the feat/multi_part_bucket_param branch December 9, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinamB BinamB BinamB left review comments

Assignees
No one assigned
Labels
@requires-fence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbeckman314 @BinamB