Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.
This repository was archived by the owner on May 3, 2022. It is now read-only.

Don't retry on unexpected Exception #1392

@jc-fireball

Description

@jc-fireball

This is created based on some feedback from our existing users.

The unexpected exception error happens because tchannel captures uncaught exceptions from endpoint handler on the side and then send unexpected error frame back to the client. Right now by default client will retry on unexpected error frame.

However most of the case if the unexpected error happens, probably the user's handler code has some bug causing this. Even we do retry and redirect to other server instance. The instance most likely has the same code deployed. It doesn't make sense to retry on this. It just waste time.

So we may change the protocol to not retry or only retry on certain flag.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions