Ensure arguments are coerced to strings in warnings (facebook#13385)

nhunzaker · web-flow · commit 5550ed4a8f33 · 2018-08-13T16:13:51.000-07:00
* Manually join extra attributes in warning

This prevents a bug where Chrome reports `Array(n)` where `n` is the
size of the array.

* Prettier

* Stringify all %s replaced symbols in warning

* Eliminate extra string coercion

* Pass args through with spread, convert all arguments to strings

* Rename strings to stringArgs
diff --git a/packages/shared/warningWithoutStack.js b/packages/shared/warningWithoutStack.js
@@ -26,7 +26,8 @@ if (__DEV__) {
       return;
     }
     if (typeof console !== 'undefined') {
-      console.error('Warning: ' + format, ...args);
+      const stringArgs = args.map(item => '' + item);
+      console.error('Warning: ' + format, ...stringArgs);
     }
     try {
       // --- Welcome to debugging React ---

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@ if (__DEV__) {`
`26`	`26`	`return;`
`27`	`27`	`}`
`28`	`28`	`if (typeof console !== 'undefined') {`
`29`		`- console.error('Warning: ' + format, ...args);`
	`29`	`+ const stringArgs = args.map(item => '' + item);`
	`30`	`+ console.error('Warning: ' + format, ...stringArgs);`
`30`	`31`	`}`
`31`	`32`	`try {`
`32`	`33`	`// --- Welcome to debugging React ---`