discussion: kprom improvement, following collector pattern

[loginakhil]

Hello there,

Thank you for your hard work in implementing such an awesome library.

Upon exploring kprom, I noticed that this module implements the Prometheus collector differently.
Instead of implementing a Prometheus collector like below:

// NewCustomCollector creates a new CustomCollector
func NewCustomCollector() *CustomCollector {
	counter := prometheus.NewCounterVec(
		prometheus.CounterOpts{
			Name: "my_custom_counter",
			Help: "A custom counter for demonstration purposes",
		},
		[]string{"label"},
	)

	prometheus.MustRegister(counter)

	return &CustomCollector{
		counter: counter,
	}
}

// Collect implements the Collector interface
func (c *CustomCollector) Collect(ch chan<- prometheus.Metric) {
	// Simulate some metrics
	c.counter.WithLabelValues("example").Inc()
	c.counter.WithLabelValues("example2").Inc()

	// Collect the metrics
	c.counter.Collect(ch)
}

// Describe implements the Collector interface
func (c *CustomCollector) Describe(ch chan<- *prometheus.Desc) {
	c.counter.Describe(ch)
}

Is there any specific reason behind this implementation style, or would you be open to approving a pull request for this modification?

[twmb]

What's the benefit of a change?

[loginakhil]

This will allow applications that use kprom to register multiple collectors to the same registry by inversing the dependency.
We will then be following the recommended approach of collector implementation

• https://github.com/prometheus/client_golang/blob/main/prometheus/collector.go#L16-L18