Skip to content

Conversation

@tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Nov 4, 2025

Feature DII-2092

Adding Token Pagination strategy

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997
Copy link
Contributor

So, in this PR, Page is still the more widely used default class and we are not implementing all 3 pagination strategy and making Page class abstract.

@tiwarishubham635
Copy link
Contributor Author

So, in this PR, Page is still the more widely used default class and we are not implementing all 3 pagination strategy and making Page class abstract.

Yes, this is because that might lead to some changes/differences in existing APIs. So to make sure the existing APIs are not affected, we are expanding the code instead of refactoring all APIs.

@sonarqubecloud
Copy link

@tiwarishubham635 tiwarishubham635 merged commit b040d51 into main Nov 24, 2025
13 checks passed
@tiwarishubham635 tiwarishubham635 deleted the add_token_pagination branch November 24, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants