Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-targeting for .NET 8.0 and drop System.Collections.Specialized for .NET 6/8 #756

Open
filipw opened this issue Aug 27, 2024 · 6 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@filipw
Copy link

filipw commented Aug 27, 2024

Issue Summary

At the moment the library does not explicitly target .NET 8.0.

This means, that referencing it from a .NET 8.0 application means going over .NET Standard 2.1, which in turn pulls a ton of very old (dating back to 2016) dependencies via System.Collections.Specialized, some of which even have CVEs on them.

Taking this into account, and given that .NET 6.0 reaches end of life in November this year, it would be good to add .NET 8.0 to multi-targeting.

Additionally, the System.Collections.Specialized should also be dropped as explicit Nuget package reference for .NET 6.0 and .NET 8.0 as it's not needed there (the necessary types are already available).

Steps to Reproduce

  1. Reference the library in a .NET 8.0 ASP.NET Core app
  2. Enable Nuget security audit by adding
    <NuGetAuditMode>all</NuGetAuditMode>
  3. Publish for Linux dotnet publish -r linux-x64
  4. Observe CVE-2019-0981 being emitted.

Technical details:

  • twilio-csharp version: 7.2.3
@AsabuHere
Copy link
Contributor

Hi @filipw, Thank you for raising this issue. This issue has been reviewed and added to our internal backlog for prioritisation . +1s and pull requests will help this move upward our backlog

Issue for tracking : https://twilio-engineering.atlassian.net/browse/DII-1699

Thanks,
Athira

@AsabuHere AsabuHere added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community labels Oct 18, 2024
@JBaltika
Copy link

JBaltika commented Oct 18, 2024

Hi team,
Can we fix this issue for .NET 8. Is it possible to make a target .NET 8 libraries only as it is the end of 2024 and its time as .NET 9 is coming in a few weeks ...

P.S it affects our prod build as security scans create errors messages.

@JBaltika
Copy link

Hi,
Any update as this screwing our production builds ... It is just a simple 10 sec fix by removing from .net6 dependency as this lib comes with .NET6 ... and later decide when to add.NET8 support.

Also, this is not an enchantment, but a bug. The current library build doesn't dependents on that old package at all

image

@go3323
Copy link

go3323 commented Oct 24, 2024

+1 please prioritize this issue.

@JBaltika
Copy link

JBaltika commented Nov 5, 2024

Hi guys, how hard is it to remove one line from Twilio.csproj line 43 and build again? Its needs 3 months of scrum meetings with hours of discussions what to do next , I guess :)
image

@elandref93
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

6 participants
@filipw @JBaltika @elandref93 @AsabuHere @go3323 and others