Remove the heart icon button to add the view as a favorite from the top bar #8769
Conversation
| isFavoriteFolderEnabled && ( | ||
| <MenuItem | ||
| LeftIcon={IconHeart} | ||
| text={'Favorite picker'} |
There was a problem hiding this comment.
@Bonapara I was not sure what to call this :), for now I have named the menu item Favorite picker
|
Hey @ehconitin! I cannot see the add/remove from favorites button in the view switcher 🤔 CleanShot.2024-11-27.at.10.11.16.mp4 |
|
@Bonapara |
|
@ehconitin we would like the view to be added directly to the favorite root level when we press "Add to Favorites". When a view is already part of favorites, the CTA should be called "Manage Favorite". Also, could you display the "Favorite" menu to the right of the |
|
Functional comments:
|
| dropdownComponents={(() => { | ||
| switch (viewPickerMode) { | ||
| case 'list': | ||
| return <ViewPickerListContent />; | ||
| case 'favorite-folders-picker': | ||
| return ( | ||
| isFavoriteFolderEnabled && <ViewPickerFavoriteFoldersDropdown /> | ||
| ); | ||
| case 'create-empty': | ||
| case 'create-from-current': | ||
| return ( | ||
| <> | ||
| <ViewPickerContentCreateMode /> | ||
| <ViewPickerContentEffect /> | ||
| </> | ||
| ); | ||
| case 'edit': | ||
| return ( | ||
| <> | ||
| <ViewPickerContentEditMode /> | ||
| <ViewPickerContentEffect /> | ||
| </> | ||
| ); | ||
| default: | ||
| return null; | ||
| } | ||
| })()} |
|
Thanks @ehconitin for your contribution! |
…op bar (twentyhq#8769) closes twentyhq#8546 @Bonapara please check the behaviour, if this is what you were looking for! ;)
closes #8546
@Bonapara please check the behaviour, if this is what you were looking for! ;)