Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "Delete" vs "Detach" Actions in Object Detail View #8698

Open
asdev29 opened this issue Nov 23, 2024 · 8 comments · May be fixed by #8818
Open

Clarify "Delete" vs "Detach" Actions in Object Detail View #8698

asdev29 opened this issue Nov 23, 2024 · 8 comments · May be fixed by #8818
Assignees
Labels
good first issue Good for newcomers

Comments

@asdev29
Copy link

asdev29 commented Nov 23, 2024

Problem Description

In the detail view of an object, there are options to "Detach" or "Delete" related fields. The current UI/UX implementation can cause confusion because:

  • Users may mistake "Delete" as an action to only break the relationship between the current object and the related object.
  • Clicking "Delete" completely removes the related object without any warning or confirmation.
  • This leads to unintended data loss, where other objects that were related to the deleted object lose their relationship as well.

Steps to Reproduce

  • Navigate to the detail view of an object with related fields.
  • Click the "Delete" option for a related field.
  • Observe that the related object is permanently deleted without any confirmation, and all other objects lose their relationship with it.
    Image

Proposed Solution

  • Introduce a confirmation popup for the "Delete" action.
  • The popup should clearly warn the user that:
  • The related object will be permanently deleted.
  • The deletion will also break all relationships with other objects linked to the related object.
  • Example confirmation message:
    "Are you sure you want to delete this related object? This action is irreversible and will break its relationship with all other associated objects."
  • Consider improving the UI to make the "Detach" and "Delete" options more distinct (e.g., different button styles or placement).
@asdev29
Copy link
Author

asdev29 commented Nov 23, 2024

Correction: it is not permanently deleted - it can be restored - but all other relationships with this object are not restored

@FelixMalfait
Copy link
Member

cc @Bonapara for input.

@Bonapara
Copy link
Member

Bonapara commented Nov 25, 2024

Hi @asdev29, thanks for raising the issue. I agree with your point. Let's add a confirmation modal when "Delete" is pressed!

Title: Delete Related Object_singular e.g. Object_singular: Companies
Description: "Are you sure you want to delete this related Object_singular? This action will break all its relationships with other objects."

@FelixMalfait FelixMalfait added the good first issue Good for newcomers label Nov 25, 2024
@artsinli
Copy link

I can tackle this

@FelixMalfait
Copy link
Member

Thanks @artsinli

@nitin251198
Copy link

@artsinli have you done this?

@khuddite
Copy link
Contributor

khuddite commented Nov 29, 2024

It seems the issue was assigned 4 days ago but not addressed yet. I created a PR here - #8818

@Weiko Weiko assigned khuddite and unassigned artsinli Nov 30, 2024
@Bonapara
Copy link
Member

Bonapara commented Dec 2, 2024

thank you @khuddite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

6 participants