-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date picker clips through navigation bar in mobile #7014
Comments
Hi, Can I contribute to this? |
Hey @Bonapara and @harshit078 can I work on this. I have already done some changes to the UI as shown in video for both full screen and mobile screen. Full Screen Full.Screen.mp4Mobile Screen Small.Screen.mp4Please tell me if any changes are needed. |
Thanks @HKS07. Is the calendar still cropped on mobile? At what point does it start getting cropped? |
I think it should work up to 360px @HKS07. We should aim for the same "desired behavior" as in this issue: #7216 I also noticed an overflow issue with the navbar in your screenshot, @harshit078: |
@Bonapara, you are correct ! It overflows through the navigation bar if the user scrolled down and it will not reposition itself. Screen.Recording.2024-09-24.at.11.02.29.AM.mov |
/oss.gg 150 |
Thanks for opening an issue! It's live on oss.gg! |
You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more. |
/assign |
Assigned to @harshrajeevsingh! Please open a draft PR linking this issue within 48h |
Hey, @Bonapara. I worked on this issue today and found that the datePicker component is overflowing not only on mobile but also on the desktop. The react-datePicker uses floating UI package to auto-position the element based on the viewport. |
@lucasbordeau will have a better idea on this ;) |
Assigned to @manav-gopal! Please open a draft PR linking this issue within 48h |
/assign |
This issue is already assigned to another person. Please find more issues here. |
Hey @manav-gopal Are you still working on this? I got it fixed. If you are not working unassign yourself. So, I can raise a PR. |
Issue unassigned. |
/assign |
Assigned to @harshrajeevsingh! Please open a draft PR linking this issue within 48h |
@harshrajeevsingh, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
2 similar comments
@harshrajeevsingh, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
@harshrajeevsingh, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
/unassign |
Issue unassigned. |
Fixes twentyhq#7014 This PR fixes date-picker overflow across all screen sizes. **Before:** ![Screenshot from 2024-10-08 23-54-20](https://github.com/user-attachments/assets/80902e3e-0f7e-4642-bda7-11cf7fa8c8af) **After:** [Screencast from 2024-10-08 23-41-36.webm](https://github.com/user-attachments/assets/a02c2866-8784-4e19-b914-ac3e97512dce)
Bug Description
Current Behaviour
Expected behavior
It should automatically reposition it's orientation to top just like Phone number field.
The text was updated successfully, but these errors were encountered: