Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date picker clips through navigation bar in mobile #7014

Closed
harshit078 opened this issue Sep 12, 2024 · 25 comments · Fixed by #7514
Closed

Date picker clips through navigation bar in mobile #7014

harshit078 opened this issue Sep 12, 2024 · 25 comments · Fixed by #7514
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@harshit078
Copy link
Contributor

Bug Description

  • Go to people in companies/people, Choose any Last update/Creation date and scroll to end of the page.
  • this only happens when scrolled to either the end of page or with respect to the section

Current Behaviour

Screenshot 2024-09-13 at 12 59 50 AM Screenshot 2024-09-13 at 1 00 38 AM

Expected behavior

It should automatically reposition it's orientation to top just like Phone number field.
Screenshot 2024-09-13 at 1 01 55 AM

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement labels Sep 13, 2024
@sephialaureenciaa
Copy link

Hi, Can I contribute to this?

@HKS07
Copy link
Contributor

HKS07 commented Sep 20, 2024

Hey @Bonapara and @harshit078 can I work on this.

I have already done some changes to the UI as shown in video for both full screen and mobile screen.

Full Screen

Full.Screen.mp4

Mobile Screen

Small.Screen.mp4

Please tell me if any changes are needed.

@Bonapara
Copy link
Member

Thanks @HKS07. Is the calendar still cropped on mobile? At what point does it start getting cropped?

@HKS07
Copy link
Contributor

HKS07 commented Sep 23, 2024

It is starting cropped around 420 px [width].

image

Shouldn't there be media query used to make it compatible for small size devices? If yes, then what width should I target?

@Bonapara
Copy link
Member

Bonapara commented Sep 23, 2024

I think it should work up to 360px @HKS07. We should aim for the same "desired behavior" as in this issue: #7216

I also noticed an overflow issue with the navbar in your screenshot, @harshit078:

CleanShot 2024-09-23 at 18 45 46

@harshit078
Copy link
Contributor Author

@Bonapara, you are correct ! It overflows through the navigation bar if the user scrolled down and it will not reposition itself.

Screen.Recording.2024-09-24.at.11.02.29.AM.mov

@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

/oss.gg 150

Copy link

oss-gg bot commented Oct 1, 2024

Thanks for opening an issue! It's live on oss.gg!

Copy link

oss-gg bot commented Oct 2, 2024

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

@harshrajeevsingh
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 2, 2024

Assigned to @harshrajeevsingh! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@harshrajeevsingh harshrajeevsingh removed their assignment Oct 3, 2024
@harshrajeevsingh
Copy link
Contributor

harshrajeevsingh commented Oct 3, 2024

Hey, @Bonapara. I worked on this issue today and found that the datePicker component is overflowing not only on mobile but also on the desktop. The react-datePicker uses floating UI package to auto-position the element based on the viewport.
After debugging, I found that floating UI is not working for the datePicker component because it's wrapped inside a parent div. Therefore, we need to remove the parent div to make this work. Down below I attached some screenshots to check.
Lemme know what approach should I take.

Before:
Screenshot from 2024-10-04 01-28-18

After:
Screenshot from 2024-10-04 01-30-40
Screenshot from 2024-10-04 01-31-47

@Bonapara
Copy link
Member

Bonapara commented Oct 4, 2024

@lucasbordeau will have a better idea on this ;)

Copy link

oss-gg bot commented Oct 4, 2024

Assigned to @manav-gopal! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@harshrajeevsingh
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 8, 2024

This issue is already assigned to another person. Please find more issues here.

@harshrajeevsingh
Copy link
Contributor

Hey @manav-gopal Are you still working on this? I got it fixed. If you are not working unassign yourself. So, I can raise a PR.

@oss-gg oss-gg bot unassigned manav-gopal Oct 8, 2024
Copy link

oss-gg bot commented Oct 8, 2024

Issue unassigned.

@harshrajeevsingh
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 8, 2024

Assigned to @harshrajeevsingh! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 10, 2024

@harshrajeevsingh, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

2 similar comments
Copy link

oss-gg bot commented Oct 12, 2024

@harshrajeevsingh, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 14, 2024

@harshrajeevsingh, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@charlesBochet
Copy link
Member

/unassign

Copy link

oss-gg bot commented Oct 14, 2024

Issue unassigned.

harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
Fixes twentyhq#7014

This PR fixes date-picker overflow across all screen sizes. 

**Before:**
![Screenshot from 2024-10-08
23-54-20](https://github.com/user-attachments/assets/80902e3e-0f7e-4642-bda7-11cf7fa8c8af)

**After:**
[Screencast from 2024-10-08
23-41-36.webm](https://github.com/user-attachments/assets/a02c2866-8784-4e19-b914-ac3e97512dce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants