Fix: Aligned floating label position correctly as said in the issue #40374 #40735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Alken0
reviewed
Sep 3, 2024
| @@ -1077,6 +1077,9 @@ $form-floating-input-padding-b: .625rem !default; | |||
| $form-floating-label-height: 1.5em !default; | |||
| $form-floating-label-opacity: .65 !default; | |||
| $form-floating-label-transform: scale(.85) translateY(-.5rem) translateX(.15rem) !default; | |||
There was a problem hiding this comment.
$form-floating-label-transform is probably no longer needed.
There was a problem hiding this comment.
Should I remove this line and create a new PR then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the issue, fixed the alignment of the floating label position correctly with newly made variables in the _variables.scss file.
Motivation & Context
This PR changes the misalignment of the floating label as described in this issue
Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #40734