-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing 'grid' and 'g-col-*' Classes #40726
Comments
I think you updated the CDN but the npm package is still missing these classes |
Coming here from this This is indeed the issue I was facing, the 5.3.2 version I was using was locally hosted and does not have ".grid". |
Hey there, thanks for your contribution to the project. The grid part is disabled by default for now as explained in CSS Grid. It means that the classes aren't embedded in the CDN packages right now. You can still enable it easily using npm by setting `$enable-cssgrid: true;
// fusv-enable
@import "../../../scss/grid"; So now time to your questions:
They are part of it but need to be enabled first via Sass option.
Feel free to open a PR changing the documentation to discuss about it. However, the example you pointed out seems to explain the usage of gap rather than a display issue. Would a link to CSS Grid page be enough ? |
Whilst I understand the above and appreciate it is your choice to make, just as a point of discussion, my workflow was :-
The result was that the examples did not work because of missing classes in the dist files. I understand your post, but doesn't that then prohibit the use of the project in the way I've described? Shouldn't the dist/ folder just be removed from the repo and installation instructions amended to suggest that it is not a method available to end-users anymore? I'm not trying to be argumentative, just trying to reduce confusion and support requests. |
You're right on your workflow and the way to use the project. I think the main problem here is that we use something opt-in in a page that does mention it but very far away and not in the context. The thing was done a long time ago so I don't have the historic for this. I don't think we'd remove our dist files because they are the ones used in the CDNs, and used by many people. From my pov, the best of the 2 worlds would be change the example in order to use flexboxes rather than a custom opt-in |
A couple months ago I really wanted to use or at least test out the |
Well, that was a really disappointing fix. Why not just compile it with |
The documentation is already compiled with We decided to remove the However, if you have ideas for a more effective way to organize this information, we’d love to hear them. Feel free to open a new PR with your suggestions! @phazei |
Prerequisites
Describe the issue
While working with Bootstrap v5.3.3, I encountered a potential inconsistency in the documentation regarding the usage of certain CSS classes.
In the Spacing Utilities documentation under the "Gap" section, the following example is provided:
Upon attempting to replicate this example in a project, I noticed that the classes grid and g-col-6 do not exist in the Bootstrap CSS provided via the CDN (https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css). Instead, these classes seem to be defined in the docs.css file used specifically for Bootstrap's documentation.
To illustrate this, I've created a CodePen example. In this example:
Questions:
Understanding the distinction between documentation-specific styles and core Bootstrap styles is crucial for developers aiming to implement features accurately. Any clarification on this matter would be greatly appreciated.
Reduced test cases
CodePen: Bootstrap Grid Gap Example
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5.3.3
The text was updated successfully, but these errors were encountered: