Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding more automated tests #17

Open
tvhong opened this issue Feb 20, 2023 · 4 comments
Open

Investigate adding more automated tests #17

tvhong opened this issue Feb 20, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@tvhong
Copy link
Owner

tvhong commented Feb 20, 2023

The automated tests available for this add-on is quite minimal. We want to add more automated tests to prevent regressions.

Let's use this issue to start the investigation.

Acceptance Criteria:

  • Have a good understanding of which part of the add-on could be tested, and how much effort it would take.
  • Document the findings here.
@tvhong tvhong changed the title Add more automated tests Investigate adding more automated tests Feb 20, 2023
@tvhong tvhong added the enhancement New feature or request label Feb 20, 2023
@tvhong
Copy link
Owner Author

tvhong commented Mar 16, 2023

I saw this this pytest-anki by glutanimate in https://github.com/artyompetrov/AutoDefine_oxfordlearnersdictionaries/blob/master/tests/tests.py .

We might be able to use it. But beware that there might be some problems running pytest-anki on MacOS.

@tvhong
Copy link
Owner Author

tvhong commented Mar 19, 2023

More tests would have prevented issues such as: #18

@tvhong
Copy link
Owner Author

tvhong commented Jan 5, 2025

Just noticed that pytest-anki hasn't seen new commits for 3 years. Probably not in a healthy place to use.

@tvhong
Copy link
Owner Author

tvhong commented Jan 5, 2025

Another concern is that the current code in the IR plugin is too tightly coupled with Anki and PyQt, making it extremely difficult to test.

We should first refactor the main logic into their own components and create unit tests for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant