Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_url missing in uploader ? #95

Open
salimkanoun opened this issue Jun 17, 2024 · 3 comments
Open

get_url missing in uploader ? #95

salimkanoun opened this issue Jun 17, 2024 · 3 comments

Comments

@salimkanoun
Copy link

Hi there in the uploader class it mention a get_url method to retrieve the uploaded file url
`get_url()
Return the tus upload url.

If resumability is enabled, this would try to get the url from storage if available, otherwise it would request a new upload url from the tus server.`

But seems to be missing in the code, is it normal ?

The internal property uploader.url is accessible an contains the url, but probably better to access it through a getter

@Acconut
Copy link
Member

Acconut commented Jun 17, 2024

I don't see a mention of a get_url in the code base. Could you send a link to the corresponding code section?

@salimkanoun
Copy link
Author

@Acconut
Copy link
Member

Acconut commented Jun 18, 2024

Ah, ok, I see. Thanks for noticing this. This documentation hasn't been updated in some time and is no longer in sync with the source code. We need to update this.

As far as I can tell, the get_url method was removed in 2020, although I don't know why: 2548bbf#diff-97989457ef05ef7429f22c43163bf6cc86bb7ae0b44379de7a06c8b35fcd8aaaL202

It's probably best and safe to directly access the url property for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants