@tus/server: Split to multiple chunks on large incoming buffer #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling incoming request, each buffer length is 64kb which
StreamSplitter
can handle without issues.But in tests we might create buffers much larger than single part size, which might not be split as expected.
Works:
const readStream = Readable.from(Buffer.alloc(expectedChunks * optimalChunkSize))
Doesn't work:
const readStream = Readable.from(
[
Buffer.alloc(expectedChunks * optimalChunkSize)
]
)