Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow App GitHub Personal Access Tokens to be saved without error. #35

Closed
wants to merge 2 commits into from
Closed

Allow App GitHub Personal Access Tokens to be saved without error. #35

wants to merge 2 commits into from

Conversation

kendavis2
Copy link

@kendavis2 kendavis2 commented Sep 18, 2020 •
edited
Loading

To allow the portal encrypt access to the KMS key used to protect GitHub Personal Access Tokens, the KMS key policy should include the portals app role in the allowed list for encryption.

@kendavis2 kendavis2 linked an issue Sep 18, 2020 that may be closed by this pull request
KMS access denied when trying to save an app with the GitHub PAT option populated. #34
Open
@kendavis2
Copy link
Author

This improvement was already introduced in a separate commit.

@kendavis2 kendavis2 closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalmena dalmena dalmena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KMS access denied when trying to save an app with the GitHub PAT option populated.
2 participants
@kendavis2 @dalmena