Help with a rotary encoder

[thesyncopater]

I have built a control surface with 9 pots, 7 rotary encoders and 7 buttons. The pots (except 1) and the buttons are connected to two multiplexers, and the encoders are connected to the Arduino digital inputs. I'm using an Arduino Zero.

I'm having trouble with a single rotary encoder that I have (1 of 7). All the other buttons, pots, and encoders are working except for one of the encoders. I've checked all the wiring connections but I'm still baffled. I was initially concerned about the interrupt pin layout and tried to add a line to optimize the interrupts (that I found on the encoder library page).

This is the segment in question.

CCRotaryEncoder enc1  = {
  {3, 14},       // pins
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_3}, 
  1,            // multiplier 
};

The rest of the code is below. There's probably ways to make this code shorter and more efficient but as of now that might be beyond my skills. Thanks for any help you might have.

/**
 * Brice Taylor's Control Surface
 * 
 *  Credit to PieterP, 2018-08-29  
 *  https://github.com/tttapa/Control-Surface
 */
#define ENCODER_OPTIMIZE_INTERRUPTS
#include <Encoder.h> // Include the Encoder library.
// This must be done before the Control Surface library.
#include <Control_Surface.h> // Include the Control Surface library
// Instantiate a MIDI over USB interface.
USBMIDI_Interface midi;




// Instantiate an analog multiplexers
CD74HC4051 mux1 = {
  A4,       //  input pin
  {0, 1, 2} // Address pins S0, S1, S2
};


// Instantiate a second analog multiplexer
CD74HC4051 mux2 = {
  4,       //  input pin
  {0, 1, 2} // Address pins S0, S1, S2
};


// Instantiate a CCPotentiometer objects (faders)/////////////////////////////////////////
CCPotentiometer fader1 = {
  mux1.pin(0),                                  
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_4},
};
CCPotentiometer fader2 = {
  mux1.pin(1),                                   
  {MIDI_CC::General_Purpose_Controller_2, CHANNEL_4}, 
};
CCPotentiometer fader3 = {
  mux1.pin(2),                                  
  {MIDI_CC::General_Purpose_Controller_3, CHANNEL_4}, 
};
CCPotentiometer fader4 = {
  mux1.pin(3),                                 
  {MIDI_CC::General_Purpose_Controller_4, CHANNEL_4}, 
};
CCPotentiometer fader5 = {
  mux1.pin(4),                                  
  {MIDI_CC::General_Purpose_Controller_5, CHANNEL_4}, 
};
CCPotentiometer fader6 = {
  mux1.pin(5),                                  
  {MIDI_CC::General_Purpose_Controller_6, CHANNEL_4}, 
};
CCPotentiometer fader7 = {
  mux1.pin(6),                                  
  {MIDI_CC::General_Purpose_Controller_7, CHANNEL_4}, 
};
CCPotentiometer fader8 = {
  mux1.pin(7),                                   
  {MIDI_CC::General_Purpose_Controller_8, CHANNEL_4}, 
};
CCPotentiometer fader9 = {
  A5,                                  
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_5}, 
};




//////////////////////////////////////////////////////////////////////////////////////////
// Buttons
CCButton button1 = {
  mux2.pin(1),                     
  {MIDI_CC::General_Purpose_Controller_2, CHANNEL_2}, 
};
CCButton button2 = {
  mux2.pin(2),                     
  {MIDI_CC::General_Purpose_Controller_3, CHANNEL_2}, 
};
CCButton button3 = {
  mux2.pin(3),                     
  {MIDI_CC::General_Purpose_Controller_4, CHANNEL_2}, 
};
CCButton button4 = {
  mux2.pin(4),                     
  {MIDI_CC::General_Purpose_Controller_5, CHANNEL_2}, 
};
CCButton button5 = {
  mux2.pin(5),                     
  {MIDI_CC::General_Purpose_Controller_6, CHANNEL_2}, 
};
CCButton button6 = {
  mux2.pin(6),                     
  {MIDI_CC::General_Purpose_Controller_7, CHANNEL_2}, 
};
CCButton button7 = {
  mux2.pin(7),                     
  {MIDI_CC::General_Purpose_Controller_8, CHANNEL_2}, 
};
///////////////////////////////////////////////////////////////////////////////////////
// Rotary Encoders
CCRotaryEncoder enc1  = {
  {3, 14},       // pins
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_3}, 
  1,            // multiplier 
};
CCRotaryEncoder enc2  = {
  {5, 6},       // pins
  {MIDI_CC::General_Purpose_Controller_2, CHANNEL_3}, 
  1,            // multiplier 
};
CCRotaryEncoder enc3  = {
  {7, 8},       // pins
  {MIDI_CC::General_Purpose_Controller_3, CHANNEL_3}, 
  1,            // multiplier 
};
CCRotaryEncoder enc4  = {
  {9, 10},       // pins
  {MIDI_CC::General_Purpose_Controller_4, CHANNEL_3}, 
  1,            // multiplier 
};
CCRotaryEncoder enc5  = {
  {11, 12},       // pins
  {MIDI_CC::General_Purpose_Controller_5, CHANNEL_3}, 
  1,            // multiplier 
};
CCRotaryEncoder enc6  = {
  {13, 17},       // pins
  {MIDI_CC::General_Purpose_Controller_6, CHANNEL_3}, 
  1,            // multiplier 
};
CCRotaryEncoder enc7  = {
  {15, 16},       // pins
  {MIDI_CC::General_Purpose_Controller_7, CHANNEL_3}, 
  1,            // multiplier 
};

///////////////////////////////////////////////////////////////////////////


void setup() {

Control_Surface.begin(); // Initialize Control Surface
  mux1.begin();
  mux2.begin();
}

void loop() {
  Control_Surface.loop(); // Update the Control Surface
}

[tttapa]

Which version of Control Surface are you using? Did you install version 1.2.0, master or new-input.

This thread might be useful: #328

If you're using the new-input branch, do not #include <Encoder.h>.

[thesyncopater]

I'm using master, version 1.2.0. Interesting tidbit from the encoder library having issues with the Zero. Is it worth trying the new-input branch?

[tttapa]

Yes, it includes some improvements to the Encoder library, and it seems like the user in #328 got it to work.

I don't own an Arduino Zero, so I can't test it myself.

[EvgeniySavkin]

CCRotaryEncoder enc1  = {
  {3, 14},       // pins
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_3}, 
  1,            // multiplier 
};

On some versions of arduino zero 14 pin is occupied by UART Tx

[thesyncopater]

Thanks for the help.

I tried using the new-input branch, and also swapping some inputs around so that the encoder in question uses input 18 (on the A4 not the SDS) instead of 14. I haven't had any luck with those changes. I'm wondering if the zero actually has enough inputs to handle all the various connections to the controller.