Fix selector resolution with async KiCad footprints

Author: Aqil-Ahmad

lib/components/base-components/NormalComponent/NormalComponent_doInitialPcbFootprintStringRender.ts

@@ -17,6 +17,39 @@ interface FootprintLibraryResult {
   cadModel?: CadModelProp
 }
 
+/**
+ * After async footprint loading, mark ports and connected traces dirty
+ * so they re-run their render phases with the new pads available
+ */
+function markPortsAndTracesForRerender(component: NormalComponent<any, any>) {
+  // Mark ports dirty for PcbPortRender so they can match with new pads
+  for (const child of component.children) {
+    if (child.componentName === "Port") {
+      child._markDirty?.("PcbPortRender")
+    }
+  }
+  component._markDirty("InitializePortsFromChildren")
+
+  // Mark traces connected to this component dirty for re-rendering
+  const allTraces = component.root?.selectAll("trace") ?? []
+  for (const trace of allTraces) {
+    // Check if this trace has a _findConnectedPorts method (it's a Trace component)
+    const findPorts = (trace as any)._findConnectedPorts
+    if (typeof findPorts !== "function") continue
+
+    // Check if any port in this trace belongs to our component
+    const result = findPorts.call(trace)
+    if (!result.allPortsFound || !result.ports) continue
+
+    const isConnected = result.ports.some(
+      (port: any) => port.getParentNormalComponent?.() === component,
+    )
+    if (isConnected) {
+      trace._markDirty?.("PcbManualTraceRender")
+    }
+  }
+}
+
 export function NormalComponent_doInitialPcbFootprintStringRender(
   component: NormalComponent<any, any>,
   queueAsyncEffect: (name: string, effect: () => Promise<void>) => void,
@@ -58,7 +91,7 @@ export function NormalComponent_doInitialPcbFootprintStringRender(
           result.footprintCircuitJson,
         )
         component.addAll(fpComponents)
-        component._markDirty("InitializePortsFromChildren")
+        markPortsAndTracesForRerender(component)
       } catch (err) {
         const db = component.root?.db
         if (db && component.source_component_id && component.pcb_component_id) {
@@ -104,7 +137,7 @@ export function NormalComponent_doInitialPcbFootprintStringRender(
           soup as any,
         )
         component.addAll(fpComponents)
-        component._markDirty("InitializePortsFromChildren")
+        markPortsAndTracesForRerender(component)
       } catch (err) {
         const db = component.root?.db
         if (db && component.source_component_id && component.pcb_component_id) {
@@ -176,13 +209,7 @@ export function NormalComponent_doInitialPcbFootprintStringRender(
         if (!Array.isArray(result) && result.cadModel) {
           component._asyncFootprintCadModel = result.cadModel
         }
-        // Ensure existing Ports re-run PcbPortRender now that pads exist
-        for (const child of component.children) {
-          if (child.componentName === "Port") {
-            child._markDirty?.("PcbPortRender")
-          }
-        }
-        component._markDirty("InitializePortsFromChildren")
+        markPortsAndTracesForRerender(component)
       } catch (err) {
         const db = component.root?.db
         if (db && component.source_component_id && component.pcb_component_id) {

lib/components/base-components/PrimitiveComponent/PrimitiveComponent.ts

@@ -600,6 +600,11 @@ export abstract class PrimitiveComponent<
     component.onAddToParent(this)
     component.parent = this
     this.children.push(component)
+
+    // Clear selector caches when children are added
+    // This is important for async footprint loading where ports are added
+    // after initial selector queries may have been cached
+    this._clearSelectorCaches()
   }
 
   addAll(components: PrimitiveComponent[]) {
@@ -612,6 +617,9 @@ export abstract class PrimitiveComponent<
     this.children = this.children.filter((c) => c !== component)
     this.childrenPendingRemoval.push(component)
     component.shouldBeRemoved = true
+
+    // Clear selector caches when children are removed
+    this._clearSelectorCaches()
   }
 
   getSubcircuitSelector(): string {
@@ -752,6 +760,20 @@ export abstract class PrimitiveComponent<
     return result2
   }
 
+  /**
+   * Clear selector caches in this component and propagate up to parent
+   * This is necessary when children are added/removed or when async operations
+   * like footprint loading complete
+   */
+  _clearSelectorCaches() {
+    this._cachedSelectOneQueries.clear()
+    this._cachedSelectAllQueries.clear()
+    // Clear parent caches too, as adding children affects parent's selectAll results
+    if (this.parent && !this.parent.isSubcircuit) {
+      this.parent._clearSelectorCaches()
+    }
+  }
+
   _cachedSelectOneQueries: Map<string, PrimitiveComponent | null> = new Map()
   selectOne<T = PrimitiveComponent>(
     selectorRaw: string,

lib/components/primitive-components/Trace/Trace.ts

@@ -311,6 +311,27 @@ export class Trace
     Trace_doInitialPcbManualTraceRender(this)
   }
 
+  updatePcbManualTraceRender(): void {
+    if (!this.root?.db) return
+
+    // Clean up old trace data before re-rendering
+    if (this.pcb_trace_id) {
+      this.root.db.pcb_trace.delete(this.pcb_trace_id)
+      this.pcb_trace_id = null
+    }
+
+    // Clean up old errors for this trace
+    const oldErrors = this.root.db.pcb_trace_error
+      .list()
+      .filter((e) => e.source_trace_id === this.source_trace_id)
+    for (const error of oldErrors) {
+      this.root.db.pcb_trace_error.delete(error.pcb_trace_error_id)
+    }
+
+    // Re-run manual trace rendering with updated port matching
+    Trace_doInitialPcbManualTraceRender(this)
+  }
+
   doInitialPcbTraceRender(): void {
     Trace_doInitialPcbTraceRender(this)
   }

tests/repros/__snapshots__/repro-kicad-footprint-pcbpath-selector.test.tsx-kicad-footprint-selectors-pcb.snap.svg

@@ -0,0 +1,99 @@
+import { test, expect } from "bun:test"
+import { getTestFixture } from "tests/fixtures/get-test-fixture"
+import kicadModJson from "tests/fixtures/assets/R_0402_1005Metric.json" with {
+  type: "json",
+}
+
+test("trace pcbPath selectors work with kicad footprints", async () => {
+  const { circuit } = getTestFixture()
+
+  circuit.platform = {
+    footprintLibraryMap: {
+      kicad: async (footprintName: string) => {
+        return {
+          footprintCircuitJson: kicadModJson,
+        }
+      },
+    },
+  }
+
+  circuit.add(
+    <board width="10mm" height="10mm">
+      <resistor
+        name="R1"
+        resistance="10k"
+        footprint="kicad:Resistor_SMD/R_0402_1005Metric"
+        pcbX={-3}
+        pcbY={0}
+      />
+      <resistor
+        name="R2"
+        resistance="10k"
+        footprint="kicad:Resistor_SMD/R_0402_1005Metric"
+        pcbX={3}
+        pcbY={0}
+      />
+      <trace
+        from=".R1 > .pin2"
+        to=".R2 > .pin1"
+        pcbPathRelativeTo=".R1 > .pin2"
+        pcbPath={["R1.pin2", { x: 0, y: 4 }, "R2.pin1"]}
+        thickness="0.5mm"
+      />
+    </board>,
+  )
+
+  await circuit.renderUntilSettled()
+
+  // Verify no selector resolution errors
+  const selectorErrors = circuit.db.pcb_trace_error
+    .list()
+    .filter((e) => e.message?.includes("Could not resolve pcbPath selector"))
+  expect(selectorErrors.length).toBe(0)
+
+  // Verify trace was created with manual routing
+  const pcbTrace = circuit.db.pcb_trace.list()[0]
+  expect(pcbTrace).toBeDefined()
+  expect(pcbTrace.route.length).toBeGreaterThanOrEqual(3)
+
+  await expect(circuit).toMatchPcbSnapshot(
+    `${import.meta.path}-kicad-footprint-selectors`,
+  )
+})
+
+test("trace pcbPath selectors work with regular footprints (baseline)", async () => {
+  const { circuit } = getTestFixture()
+
+  circuit.add(
+    <board width="10mm" height="10mm">
+      <resistor
+        name="R1"
+        resistance="10k"
+        footprint="0402"
+        pcbX={-3}
+        pcbY={0}
+      />
+      <resistor name="R2" resistance="10k" footprint="0402" pcbX={3} pcbY={0} />
+      <trace
+        from=".R1 > .pin2"
+        to=".R2 > .pin1"
+        pcbPathRelativeTo=".R1 > .pin2"
+        pcbPath={["R1.pin2", { x: 0, y: 4 }, "R2.pin1"]}
+        thickness="0.5mm"
+      />
+    </board>,
+  )
+
+  await circuit.renderUntilSettled()
+
+  const pcbTrace = circuit.db.pcb_trace.list()[0]
+  expect(pcbTrace).toBeDefined()
+
+  // Verify trace width is applied correctly
+  const wireSegments = pcbTrace.route.filter((s) => s.route_type === "wire")
+  expect(wireSegments.every((s) => s.width === 0.5)).toBe(true)
+
+  await expect(circuit).toMatchPcbSnapshot(
+    `${import.meta.path}-regular-footprint-selectors`,
+  )
+})