Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a wrapper over f32 for Value #289

Open
andreubotella opened this issue Jul 7, 2024 · 0 comments
Open

Consider adding a wrapper over f32 for Value #289

andreubotella opened this issue Jul 7, 2024 · 0 comments

Comments

@andreubotella
Copy link
Collaborator

Currently it is possible to do Value::Float(0.0), which would create an invalid value, because the canonical representation of (positive) zero is Value::Integer(SmallInteger::zero()). Rather than using f32 as the value for the Float variant, we should instead use a transparent wrapper type that checks the value cannot be invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant