Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got "Visitor error" when I canceled the importer #1093

Open
helio-frota opened this issue Dec 11, 2024 · 4 comments
Open

Got "Visitor error" when I canceled the importer #1093

helio-frota opened this issue Dec 11, 2024 · 4 comments

Comments

@helio-frota
Copy link
Collaborator

2024-12-11_07-54

maybe nice to have Error: instead of Visitor error: ?

@carlosthe19916
Copy link
Member

@helio-frota thanks for opening the issue. I think your point is to avoid exposing words that only make sense to the internal system but difficult to digest for the final user. If that is the case I think your point is a valid one.

However, the UI has no way of changing the message Visitor error: by Error: as that is a String generated in the backend REST API.

``Visitor error:` is a STRING that is originated in the REST API, therefore the "words" need to be changed there.

@helio-frota
Copy link
Collaborator Author

I think your point is to avoid exposing words that only make sense to the internal system but difficult to digest for the final user. If that is the case I think your point is a valid one.

yes that's correct 👍

@carlosthe19916
Copy link
Member

Moving this issue to the trustify repository as it is more appropriate to track it there.

@carlosthe19916 carlosthe19916 transferred this issue from trustification/trustify-ui Dec 11, 2024
@helio-frota
Copy link
Collaborator Author

helio-frota commented Dec 13, 2024

I found a place where this is happening

-            .map_err(|err| ScannerError::Normal {
-                err: err.into(),
+            .map_err(|_err| ScannerError::Normal {
+                err: anyhow!("aaa"),

2024-12-13_08-41

I'm trying to understand how to make the change in proper way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants