Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSV importer does not consider startYear #1087

Closed
dejanb opened this issue Dec 9, 2024 · 1 comment
Closed

OSV importer does not consider startYear #1087

dejanb opened this issue Dec 9, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@dejanb
Copy link
Contributor

dejanb commented Dec 9, 2024

Creating an OSV importer like

http -v POST localhost:8080/api/v1/importer/osv-github "osv[source]=https://github.com/github/advisory-database" "osv[path]=advisories" "osv[startYear]=2024" "osv[disabled]:=false" "osv[period]=30m" "osv[v3Signatures]:=true"

I would expect that startYear is used in a similar fashion like in the CSAF importer. The start year is however ignored and the whole repo is being ingested.

$ http GET localhost:8080/api/v1/importer/osv-github
HTTP/1.1 200 OK
access-control-allow-credentials: true
access-control-expose-headers: etag, content-type
content-encoding: gzip
content-type: application/json
date: Mon, 09 Dec 2024 12:47:48 GMT
etag: "86abcee4-617b-48d4-8cc8-1e1edc9d2351"
transfer-encoding: chunked
vary: Origin, Access-Control-Request-Method, Access-Control-Request-Headers
vary: accept-encoding

{
    "configuration": {
        "osv": {
            "disabled": false,
            "path": "advisories",
            "period": "30m",
            "source": "https://github.com/github/advisory-database"
        }
    },
    "lastChange": "2024-12-09T09:57:05.77046Z",
    "name": "osv-github",
    "progress": {
        "current": 147114,
        "estimatedCompletion": "2024-12-09T14:55:47.188473Z",
        "estimatedSecondsRemaining": 7679,
        "percent": 0.57149625,
        "rate": 14.36321,
        "total": 257419
    },
    "state": "running"
}
@dejanb dejanb added the good first issue Good for newcomers label Dec 9, 2024
@ctron
Copy link
Contributor

ctron commented Dec 18, 2024

Should be closed by #1101

@ctron ctron closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants