Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Update Ganache to 7.9.1; turn off Node 14 and turn on Node 20 (and fix a bad type) #6169

Merged
merged 15 commits into from
Aug 25, 2023

Conversation

haltman-at
Copy link
Contributor

As described!

I noticed some warnings in dashboard when bootstrapping this one that I hadn't seen before? But that may possibly be due to me switching to Node 16 rather than using Node 14 like I had been.

@haltman-at haltman-at added dependencies Pull requests that update a dependency file internal improvement labels Aug 22, 2023
@haltman-at
Copy link
Contributor Author

OK, added a commit to update hardhat, let's see how that goes...

hardhat
  * @truffle/dashboard-hardhat-plugin: ^2.0.0 → ^2.17.1, ^2.0.0 → ^2.17.1
  * @truffle/from-hardhat: ^2.10.1 → ^2.17.1
@haltman-at haltman-at force-pushed the ganache-and-node-forward branch from 70287d3 to 53a1647 Compare August 24, 2023 21:34
@haltman-at
Copy link
Contributor Author

OK, going with latest hardhat, but I fixed the bad type in compile-solidity.

@haltman-at haltman-at changed the title Update Ganache to 7.9.1; turn off Node 14 and turn on Node 20 Update Ganache to 7.9.1; turn off Node 14 and turn on Node 20 (and fix a bad type) Aug 24, 2023
@haltman-at
Copy link
Contributor Author

OK, I also had to update how Ganache is initialized in one place; we'll see if there are any others.

@haltman-at
Copy link
Contributor Author

OK, I have no idea why this test of truffle networks --clean keeps failing. It passes locally, including on Node 20...

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :D

@haltman-at haltman-at merged commit cc26d74 into develop Aug 25, 2023
10 checks passed
@haltman-at haltman-at deleted the ganache-and-node-forward branch August 25, 2023 18:40
@legobeat legobeat mentioned this pull request Sep 3, 2023
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐜 bug fix dependencies Pull requests that update a dependency file internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants