Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Commit

Permalink
remove comments related to issue: web3.js#6311
Browse files Browse the repository at this point in the history
  • Loading branch information
Muhammad-Altabba committed Sep 26, 2023
1 parent 4a9c99f commit df2a53a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 29 deletions.
10 changes: 0 additions & 10 deletions packages/artifactor/test/contracts.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ describe("artifactor + require", () => {
})
.then(done)
.catch(done);
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("shouldn't synchronize constant functions", done => {
Expand Down Expand Up @@ -188,8 +186,6 @@ describe("artifactor + require", () => {
})
.then(done)
.catch(done);
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("should return transaction hash, logs and receipt when using synchronised transactions", done => {
Expand Down Expand Up @@ -225,8 +221,6 @@ describe("artifactor + require", () => {
})
.then(done)
.catch(done);
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("should trigger the fallback function when calling sendTransaction()", () => {
Expand All @@ -252,8 +246,6 @@ describe("artifactor + require", () => {
"1 ether has been sent but the balance does not match that"
);
});
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("should trigger the fallback function when calling send() (shorthand notation)", () => {
Expand All @@ -277,8 +269,6 @@ describe("artifactor + require", () => {
"1 ether has been sent but the balance does not match that"
);
});
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("errors when setting an invalid provider", done => {
Expand Down
8 changes: 0 additions & 8 deletions packages/decoder/test/current/test/downgrade-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ describe("Graceful degradation when information is missing", function () {
source.ast = undefined;

await runTestBody(mangledCompilations);
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(5000);

it("Correctly degrades on allocation when error", async function () {
Expand All @@ -80,8 +78,6 @@ describe("Graceful degradation when information is missing", function () {
//the decoder from recognizing it as a struct definition

await runTestBody(mangledCompilations, true);
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("Correctly degrades on decoding when error", async function () {
Expand All @@ -101,14 +97,10 @@ describe("Graceful degradation when information is missing", function () {
//the decoder from recognizing it as a enum definition

await runTestBody(mangledCompilations, true);
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(3000);

it("Correctly abifies after finishing", async function () {
await runTestBody(compilations, false, true); //for once, we're not modifying it!
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
}).timeout(5000);

it("Correctly decodes decimals", async function () {
Expand Down
12 changes: 1 addition & 11 deletions packages/decoder/test/current/test/wire-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,7 @@ describe("Over-the-wire decoding", function () {
];
});

//todo web3.js-migration
//Error: reference "x" resolves to more than one schema
it("should correctly decode transactions and events", async function () {
// TODO: investigate why timeout needed to be increased
// issue: https://github.com/web3/web3.js/issues/6311
this.timeout(20000);
let deployedContract = await abstractions.WireTest.new(
true,
Expand Down Expand Up @@ -326,13 +322,7 @@ describe("Over-the-wire decoding", function () {
let indexTestBlock = indexTest.receipt.blockNumber;
let libraryTestBlock = libraryTest.receipt.blockNumber;

try {
//due to web3's having ethers's crappy decoder built in,
//we have to put this in a try block to catch the error
await deployedContract.danger();
} catch (_) {
//discard the error!
}
await deployedContract.danger();

let constructorEvents = await decoder.events({
fromBlock: constructorBlock,
Expand Down

0 comments on commit df2a53a

Please sign in to comment.