updated storyblok detector #3981
Open
+1,191
−847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmussani
reviewed
Mar 17, 2025
There was a problem hiding this comment.
Thanks @kashifkhan0771. Overall, looks great. Just few minor comments.
pkg/detectors/storyblok/storyblok.go
Outdated
| } | ||
| // docs: https://www.storyblok.com/docs/api/content-delivery/v2/getting-started/authentication | ||
| func verifyStoryBlokAccessToken(ctx context.Context, client *http.Client, token string) (bool, error) { | ||
| req, err := http.NewRequestWithContext(ctx, "GET", "https://api.storyblok.com/v1/cdn/spaces/me/?token="+token, nil) |
| func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) { | ||
| dataStr := string(data) | ||
|
|
||
| matches := keyPat.FindAllStringSubmatch(dataStr, -1) |
There was a problem hiding this comment.
can we put uniqueness logic here to avoid duplicates ?
|
|
||
| // docs: http://storyblok.com/docs/api/management/core-resources/spaces/retrieve-multiple-spaces | ||
| func verifyStoryBlokPersonalAccessToken(ctx context.Context, client *http.Client, token string) (bool, error) { | ||
| req, err := http.NewRequestWithContext(ctx, "GET", "https://mapi.storyblok.com/v1/spaces/", nil) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes #3909 and oss-136
Tests:
Checklist:
make test-community)?make lintthis requires golangci-lint)?