Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Extras to None is Confusing #11

Open
mlissner opened this issue Aug 28, 2015 · 2 comments
Open

Setting Extras to None is Confusing #11

mlissner opened this issue Aug 28, 2015 · 2 comments

Comments

@mlissner
Copy link
Contributor

So...I want to allow people to do cuddled lists. So, I'm like, cool, I'll turn on the cuddled-lists extra. And to do that, I set the value to...None.

Could we make it so that the value is instead set to True? I'm finding this super confusing. Even the code-friendly extra...is set to None? What does None mean in this context? I'm not sure I get it.

@chrismcginlay
Copy link

https://github.com/trentm/python-markdown2/blob/master/lib/markdown2.py#L1863

In the underlying markdown2 library, it looks like (line 1863) the value set for cuddled-lists could be anything you like; if statement just checks for the presence of the cuddled-list key in extras dict.

@mlissner
Copy link
Contributor Author

That's interesting and explains how we got to setting it to None. Maybe we should just update our docs to say that it needs to be set to True? But then people will be upset that setting it to False doesn't disable it. Perhaps this needs changing in Markdown2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants