diff --git a/.classpath b/.classpath new file mode 100644 index 0000000..018a9f0 --- /dev/null +++ b/.classpath @@ -0,0 +1,17 @@ + + + + + + + + + + + + + + + + + diff --git a/.gitignore b/.gitignore index 7a463f6..b28cb90 100644 --- a/.gitignore +++ b/.gitignore @@ -62,3 +62,4 @@ build/ !gradle-wrapper.jar +/bin/ diff --git a/.project b/.project new file mode 100644 index 0000000..9d6030e --- /dev/null +++ b/.project @@ -0,0 +1,23 @@ + + + flashy + + + + + + org.eclipse.jdt.core.javabuilder + + + + + org.eclipse.buildship.core.gradleprojectbuilder + + + + + + org.eclipse.buildship.core.gradleprojectnature + org.eclipse.jdt.core.javanature + + diff --git a/.settings/org.eclipse.buildship.core.prefs b/.settings/org.eclipse.buildship.core.prefs new file mode 100644 index 0000000..7eee74c --- /dev/null +++ b/.settings/org.eclipse.buildship.core.prefs @@ -0,0 +1,10 @@ +build.commands=org.eclipse.jdt.core.javabuilder +connection.arguments= +connection.gradle.distribution=GRADLE_DISTRIBUTION(WRAPPER) +connection.java.home=null +connection.jvm.arguments= +connection.project.dir= +derived.resources=.gradle,build +eclipse.preferences.version=1 +natures=org.eclipse.jdt.core.javanature +project.path=\: diff --git a/src/main/java/com/teamtreehouse/flashy/controllers/FlashCardController.java b/src/main/java/com/teamtreehouse/flashy/controllers/FlashCardController.java index 44766a0..a1ff4bb 100644 --- a/src/main/java/com/teamtreehouse/flashy/controllers/FlashCardController.java +++ b/src/main/java/com/teamtreehouse/flashy/controllers/FlashCardController.java @@ -22,9 +22,9 @@ public class FlashCardController { public void setFlashCardService(FlashCardService flashCardService) { this.flashCardService = flashCardService; } - + @SuppressWarnings("unchecked") private Map getCardCounts(HttpServletRequest req) { - Map cardCounts = (Map) req.getSession().getAttribute("cardCounts"); + Map cardCounts = (Map) req.getSession().getAttribute("cardCounts"); if (cardCounts == null) { cardCounts = new HashMap<>(); req.getSession().setAttribute("cardCounts", cardCounts); diff --git a/src/main/java/com/teamtreehouse/flashy/controllers/IndexController.java b/src/main/java/com/teamtreehouse/flashy/controllers/IndexController.java index f127754..a5574f9 100644 --- a/src/main/java/com/teamtreehouse/flashy/controllers/IndexController.java +++ b/src/main/java/com/teamtreehouse/flashy/controllers/IndexController.java @@ -12,6 +12,7 @@ @Controller public class IndexController { + private static final int AMOUNT_TO_SHOW = 3; private FlashCardService flashCardService; @Autowired @@ -22,7 +23,7 @@ public void setFlashCardService(FlashCardService flashCardService) { @RequestMapping("/") public String index(Model model) { StringBuilder ctaBuilder = new StringBuilder(); - List cards = flashCardService.getRandomFlashCards(5); + List cards = flashCardService.getRandomFlashCards(AMOUNT_TO_SHOW); ctaBuilder.append("Refresh your memory about "); for (FlashCard card : cards) { ctaBuilder.append(card.getTerm()); @@ -30,10 +31,14 @@ public String index(Model model) { ctaBuilder.append(", "); } } - ctaBuilder.append(" and "); Long totalCount = flashCardService.getCurrentCount(); - ctaBuilder.append(totalCount); - ctaBuilder.append(" more"); + if(totalCount > AMOUNT_TO_SHOW) + { + ctaBuilder.append(" and "); + ctaBuilder.append(totalCount - AMOUNT_TO_SHOW); + ctaBuilder.append(" more"); + } + model.addAttribute("cta", ctaBuilder.toString()); model.addAttribute("flashCardCount", totalCount); return "index"; diff --git a/src/main/java/com/teamtreehouse/flashy/services/FlashCardServiceImpl.java b/src/main/java/com/teamtreehouse/flashy/services/FlashCardServiceImpl.java index 5b660e9..0a85124 100644 --- a/src/main/java/com/teamtreehouse/flashy/services/FlashCardServiceImpl.java +++ b/src/main/java/com/teamtreehouse/flashy/services/FlashCardServiceImpl.java @@ -62,10 +62,10 @@ public FlashCard getNextFlashCardBasedOnViews(Map idToViewCounts) { continue; } Long lowestScore = idToViewCounts.get(leastViewedId); - if (entry.getValue() >= lowestScore) { - break; + if (entry.getValue() < lowestScore) { + leastViewedId = entry.getKey(); } - leastViewedId = entry.getKey(); + } return flashCardRepository.findOne(leastViewedId); }