From 310e7947ff3e17aeddfb21e5968537f60593e5b7 Mon Sep 17 00:00:00 2001
From: Sebastian Dietrich <SebDieBln@users.noreply.github.com>
Date: Sun, 27 Aug 2023 17:42:59 +0200
Subject: [PATCH 1/3] Revert to using genshi.builder.tag because the code is
 not yet compatible with trac.util.html.tag

genshi.builder.tag converts attribute names like 'data_base_url' to 'data-base-url' which makes them accessible by jQuery's .data() API. trac.util.html.tag does not do that.

fixes regression in fa7cdff4500f3a2a215645d3cd5470833dfca624
---
 code_comments/subscription.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/code_comments/subscription.py b/code_comments/subscription.py
index cbe14dc..913c2db 100644
--- a/code_comments/subscription.py
+++ b/code_comments/subscription.py
@@ -6,11 +6,11 @@
 from trac.admin import IAdminCommandProvider
 from trac.attachment import Attachment, IAttachmentChangeListener
 from trac.core import Component, implements
-from trac.util.html import html as tag
 from trac.versioncontrol import (
     RepositoryManager, NoSuchChangeset, IRepositoryChangeListener)
 from trac.web.api import HTTPNotFound, IRequestHandler, ITemplateStreamFilter
 
+from genshi.builder import tag  # Note that trac.util.html.html is NOT a drop-in replacement. (see #85)
 from genshi.filters import Transformer
 
 from code_comments.api import ICodeCommentChangeListener

From 77a3a8d343c091d2c0ddd6ef971a1e568efe484e Mon Sep 17 00:00:00 2001
From: Sebastian Dietrich <SebDieBln@users.noreply.github.com>
Date: Sun, 8 Jun 2025 15:57:47 +0200
Subject: [PATCH 2/3] Allow Backbone.View to access dynamically generated
 elements

This will be necessary to be able to dynamically create the subscription button.
---
 code_comments/htdocs/code-comments.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/code_comments/htdocs/code-comments.js b/code_comments/htdocs/code-comments.js
index fe1cda6..53bca3e 100644
--- a/code_comments/htdocs/code-comments.js
+++ b/code_comments/htdocs/code-comments.js
@@ -328,7 +328,7 @@ var underscore = _.noConflict();
 	});
 
 	window.SubscriptionView = Backbone.View.extend({
-		el: $('button#subscribe'),
+		el: 'button#subscribe',
 
 		initialize: function(){
 			_.bindAll(this, "render");

From 2934e2c8f7758db3945fd4a3f29d7bf7fa61cae7 Mon Sep 17 00:00:00 2001
From: Sebastian Dietrich <SebDieBln@users.noreply.github.com>
Date: Thu, 3 Oct 2024 23:27:13 +0200
Subject: [PATCH 3/3] Avoid ITemplateStreamFilter when adding the subscription
 button

The button is now created using javascript.
---
 code_comments/htdocs/code-comments.js | 44 +++++++++++++++++++++++++++
 code_comments/subscription.py         | 30 ++----------------
 2 files changed, 46 insertions(+), 28 deletions(-)

diff --git a/code_comments/htdocs/code-comments.js b/code_comments/htdocs/code-comments.js
index 53bca3e..40586ba 100644
--- a/code_comments/htdocs/code-comments.js
+++ b/code_comments/htdocs/code-comments.js
@@ -1,5 +1,48 @@
 var underscore = _.noConflict();
 
+function addSubscriptionButton() {
+	if (jQuery('h1').length == 0) {
+		return;
+	}
+
+	var rev = new URLSearchParams(window.location.search).get('rev') || '';
+
+	var button = jQuery(
+		'<button>',
+		{
+			id: 'subscribe',
+			disabled: true,
+			role: 'button',
+			title: 'Code comment subscriptions require JavaScript to be enabled',
+			class: 'ui-button ui-widget ui-state-default ui-corner-all ui-button-text-icon-primary',
+			'data-base-url': window.location.origin,
+			'data-path': window.location.pathname,
+			'data-rev': rev
+		}
+	);
+
+	button.append(
+		jQuery(
+			'<span>',
+			{
+				class: 'ui-button-icon-primary ui-icon ui-icon-closethick'
+			}
+		)
+	);
+
+	button.append(
+		jQuery(
+			'<span>',
+			{
+				text: 'Subscribe',
+				class: 'ui-button-text'
+			}
+		)
+	);
+
+	jQuery('h1').before(button);
+}
+
 (function($) { $(function() {
 	var _ = window.underscore,
 		jQuery = $;  // just in case something uses jQuery() instead of $()
@@ -372,6 +415,7 @@ var underscore = _.noConflict();
 	});
 
 	window.subscription = new Subscription();
+	addSubscriptionButton()
 	window.subscriptionView = new SubscriptionView({model: subscription});
 	if (subscriptionView.el) {
 		subscription.fetch();
diff --git a/code_comments/subscription.py b/code_comments/subscription.py
index 913c2db..9a3d998 100644
--- a/code_comments/subscription.py
+++ b/code_comments/subscription.py
@@ -8,10 +8,7 @@
 from trac.core import Component, implements
 from trac.versioncontrol import (
     RepositoryManager, NoSuchChangeset, IRepositoryChangeListener)
-from trac.web.api import HTTPNotFound, IRequestHandler, ITemplateStreamFilter
-
-from genshi.builder import tag  # Note that trac.util.html.html is NOT a drop-in replacement. (see #85)
-from genshi.filters import Transformer
+from trac.web.api import HTTPNotFound, IRequestHandler
 
 from code_comments.api import ICodeCommentChangeListener
 from code_comments.comments import Comments
@@ -439,7 +436,7 @@ def comment_created(self, comment):
 
 
 class SubscriptionModule(Component):
-    implements(IRequestHandler, ITemplateStreamFilter)
+    implements(IRequestHandler)
 
     # IRequestHandler methods
 
@@ -459,17 +456,6 @@ def process_request(self, req):
             return self._do_PUT(req)
         return self._do_GET(req)
 
-    # ITemplateStreamFilter methods
-
-    def filter_stream(self, req, method, filename, stream, data):
-        if re.match(r'^/(changeset|browser|attachment/ticket/\d+/.?).*',
-                    req.path_info):
-            filter = Transformer('//h1')
-            button = self._subscription_button(req.path_info,
-                                               req.args.get('rev'))
-            stream |= filter.before(button)
-        return stream
-
     # Internal methods
 
     def _do_GET(self, req):
@@ -496,15 +482,3 @@ def _do_PUT(self, req):
             subscription.update()
         req.send(json.dumps(subscription, cls=SubscriptionJSONEncoder),
                  'application/json')
-
-    def _subscription_button(self, path, rev):
-        """
-        Generates a (disabled) button to connect JavaScript to.
-        """
-        return tag.button(
-            'Subscribe', id_='subscribe', disabled=True,
-            title=('Code comment subscriptions require JavaScript '
-                   'to be enabled'),
-            data_base_url=self.env.project_url or self.env.abs_href(),
-            data_path=path,
-            data_rev=rev)