project, contestの終了時期を未定に戻す更新が出来るようにした #727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges_until_to_nil
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
+ Coverage 70.93% 70.99% +0.06%
==========================================
Files 42 42
Lines 4576 4593 +17
==========================================
+ Hits 3246 3261 +15
+ Misses 1172 1171 -1
- Partials 158 161 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
H1rono
requested changes
Dec 27, 2024
| argUntil := domain.YearWithSemester{Year: int(args.UntilYear.ValueOrZero()), Semester: int(args.UntilSemester.ValueOrZero())} | ||
| originValid := originUntil.IsValid() | ||
| // Untilが未定かどうかの状態が異なるか、Untilが異なる場合に更新 | ||
| if validYear != originValid || (validYear && argUntil != originUntil) { |
There was a problem hiding this comment.
Suggested change
| if validYear != originValid || (validYear && argUntil != originUntil) { | |
| if validYear != originValid || (validYear && argUntil.Equal(originUntil)) { |
| if validYear == validSemester { | ||
| originUntil, originValid := project1.Duration.Until.V() | ||
| argUntil := domain.YearWithSemester{Year: int(uy), Semester: int(us)} | ||
| if validYear != originValid || (validYear && argUntil != originUntil) { |
There was a problem hiding this comment.
Suggested change
| if validYear != originValid || (validYear && argUntil != originUntil) { | |
| if validYear != originValid || (validYear && argUntil.Equal(originUntil)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #694