responses/[responseID]の作成 #32
Open
+442
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cp-20
requested changes
Jan 14, 2024
There was a problem hiding this comment.
このページは個々の回答の詳細を見る画面なので、モックデータとしてpages/responses/[responseID]/index.vueでは回答のデータ (具体的には getResponse APIの結果) を含めて、それを表示するようにしてほしいです
今の実装だと/responses/newと変わらず編集画面っぽくなってる気がします。イメージが伝わってなかったならボクの責任なんですが、この画面はあくまで回答の閲覧画面 (現在のanke-toでも同じようなURLに相当するもの) なので、そういう感じでお願いします🙏
あと別件ですが、PR名はもすこし分かりやすい方がいいかもです
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.