Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebhookService構造体を作る #813

Open
H1rono opened this issue Dec 6, 2024 · 1 comment
Open

WebhookService構造体を作る #813

H1rono opened this issue Dec 6, 2024 · 1 comment
Assignees
@oER4
Labels
good first issue Good issue for new contributors to get started with v2 About Jomon version2

Comments

@H1rono
Copy link
Member

H1rono commented Dec 6, 2024

#482 の一部
@H1rono
Copy link
Member Author

H1rono commented Dec 6, 2024

Jomon/service/webhook.go

Lines 76 to 78 in 31fc9cf

webhookSecret := os.Getenv("WEBHOOK_SECRET")
webhookChannelId := os.Getenv("WEBHOOK_CHANNEL_ID")
webhookId := os.Getenv("WEBHOOK_ID")

ここをまとめて構造体にする、環境変数読み込みrouter/router.goでやるといいかな？

@H1rono H1rono added v2 About Jomon version2 good first issue Good issue for new contributors to get started with labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oER4 oER4

Labels
good first issue Good issue for new contributors to get started with v2 About Jomon version2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@H1rono @oER4