Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage report/banner #795

Open
pool2win opened this issue Sep 18, 2024 · 2 comments
Open

Add code coverage report/banner #795

pool2win opened this issue Sep 18, 2024 · 2 comments

Comments

@pool2win
Copy link

Seeing good code coverage will give confidence to other developers to use tower. It might also help find some bugs as we strive to improve coverage.

@seanmonstar
Copy link
Collaborator

Thanks for the suggestion. But I find code coverage tricky to count and report. In my experience, they tend to fail to notice various lines were covered. Many projects in Rust don't bother, and I don't think tower should either.

@GlenDC
Copy link
Contributor

GlenDC commented Sep 18, 2024

Code coverage as a metric of quality is pretty flaky. It can however be a nice tool in the back of a shed for maintainers to know if they might have some holes that they may wish to cover. But don't think it really is something an "outsider" should take as a mark of quality.

FWIW using something like tarpaulin it is fairly trivial to add a GH action for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants