Migrating a library to tower-http 0.5 (to support axum 0.7) #458

Oliboy50 · 2024-01-12T10:55:02Z

Oliboy50
Jan 12, 2024

Summary

Context

I'm trying to migrate my internal authentication lib to tower-http 0.5 (in order to support axum 0.7).

Issue

I have the following error while migrating a wrapper of AsyncRequireAuthorizationLayer (named MyLayer in this example):

error[E0277]: the trait bound `MyLayer<_>: tower_http::auth::async_require_authorization::AsyncAuthorizeRequest<Body>` is not satisfied
   |
64 |         .route_layer(
   |          ^^^^^^^^^^^ the trait `tower_http::auth::async_require_authorization::AsyncAuthorizeRequest<Body>` is not implemented for `MyLayer<_>`
   |
   = help: the trait `tower_http::auth::async_require_authorization::AsyncAuthorizeRequest<ReqBody>` is implemented for `MyLayer<ResBody>`
   = note: required for `tower_http::auth::async_require_authorization::AsyncRequireAuthorization<Route, MyLayer<_>>` to implement `Service<axum::http::Request<Body>>`

And here is the relevant part of MyLayer (something that worked well with tower-http 0.4 and axum 0.6):

impl<ResBody> MyLayer<ResBody> {
    fn new() -> AsyncRequireAuthorizationLayer<Self>
    {
        let layer = MyLayer {
            _ty: PhantomData,
        };

        AsyncRequireAuthorizationLayer::new(layer)
    }
}

impl<ReqBody, ResBody> AsyncAuthorizeRequest<ReqBody> for MyLayer<ResBody>
where
    ReqBody: Send + Sync + 'static,
    ResBody: Body + Default + 'static,
{
    type RequestBody = ReqBody;
    type ResponseBody = ResBody;
    type Future =
        BoxFuture<'static, Result<Request<Self::RequestBody>, Response<Self::ResponseBody>>>;

    fn authorize(&mut self, mut req: Request<Self::RequestBody>) -> Self::Future {
        Box::pin(async move {
            // ...
            Ok(req)
        })
    }
}

Note: I already tried to use type ResponseBody = Full<Bytes> instead of a generic ResBody parameter, as mentioned in the documentation tests. But the issue remains exactly the same.

Do you have any idea how should I upgrade this, so that it works with tower-http 0.5 and axum 0.7?

tower-http version

0.5.0

Answered by jplatte

Jan 12, 2024

axum's Body type is not Sync, but you require ReqBody: Sync. Do you actually need that bound?

View full answer

jplatte · 2024-01-12T11:22:01Z

jplatte
Jan 12, 2024
Collaborator

axum's Body type is not Sync, but you require ReqBody: Sync. Do you actually need that bound?

1 reply

Oliboy50 Jan 12, 2024
Author

No I don't even know why I had this bound in the first place 🤷.

Anyway, it fixed my issue, thank you!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrating a library to tower-http 0.5 (to support axum 0.7) #458

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment 1 reply

{{title}}

{{title}}

Select a reply

Migrating a library to tower-http 0.5 (to support axum 0.7) #458

Oliboy50 Jan 12, 2024

Summary

Context

Issue

tower-http version

Replies: 1 comment · 1 reply

jplatte Jan 12, 2024 Collaborator

Oliboy50 Jan 12, 2024 Author

Oliboy50
Jan 12, 2024

Replies: 1 comment 1 reply

jplatte
Jan 12, 2024
Collaborator

Oliboy50 Jan 12, 2024
Author