Skip to content

Commit d77ff68

Browse files
committed
show milestone approved modals disregard if there is any pending approvals
1 parent 2edd2cd commit d77ff68

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/projects/detail/components/SimplePlan/components/MilestonesApprovalNotification/MilestonesApprovalNotification.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,13 @@ class MilestonesApprovalNotification extends React.Component {
5050
const { milestones } = this.props
5151

5252
console.log('milestones', milestones)
53-
54-
const inReviews = milestones.find(
55-
(ms) => ms.status === PHASE_STATUS_IN_REVIEW
56-
)
53+
5754
const revieweds = milestones.filter(
5855
(ms) => ms.status === PHASE_STATUS_REVIEWED
5956
).map( ms => {ms.currentApproval = this.findLatest(ms.approvals); return ms})
6057

6158
const showAllApproved =
62-
!inReviews && revieweds.length > 0 &&
59+
revieweds.length > 0 &&
6360
!revieweds.find(
6461
(rd) =>
6562
!!(

0 commit comments

Comments
 (0)