Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide filter button when there is only ProgrammingTextFilter in the filter list #50

Open
dvlprb2 opened this issue Dec 30, 2024 · 4 comments · May be fixed by #51
Open

Hide filter button when there is only ProgrammingTextFilter in the filter list #50

dvlprb2 opened this issue Dec 30, 2024 · 4 comments · May be fixed by #51

Comments

@dvlprb2
Copy link

dvlprb2 commented Dec 30, 2024

Thank you for this amazing library! I appreciate the effort that went into building it.

I have encountered a small issue when using the ProgrammingTextFilter. Specifically:

When I add only the ProgrammingTextFilter, the filter form appears empty. However, in such cases, I believe the entire filter bar should be hidden, or there should be a configurable option in the theme data to show or hide the filter bar dynamically based on its content.

This behavior seems unintuitive as the empty filter bar doesn’t add value to the UI when no actual filters are present.
@tomasweigenast
Copy link
Owner

Hey! I don't have much time to work on this library, but I will keep this open and try to fix it ASAP. Thank you

@dvlprb2
Copy link
Author

dvlprb2 commented Dec 31, 2024

Hey! I don't have much time to work on this library, but I will keep this open and try to fix it ASAP. Thank you

Should I submit PR, can you review and approve it?

I urgently need it for a project I am currently working on and it is just a small feature.

@tomasweigenast
Copy link
Owner

tomasweigenast commented Dec 31, 2024 via email

@dvlprb2
Copy link
Author

dvlprb2 commented Dec 31, 2024

I have submitted a PR please try to review and approve it ASAP. Thank you.

PR - #51

@tomasweigenast tomasweigenast linked a pull request Jan 2, 2025 that will close this issue
Added feature: Hide Filter Bar #51
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added feature: Hide Filter Bar dvlprb2/paged-datatable
2 participants
@dvlprb2 @tomasweigenast