Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles to support printing the tutorial #771

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sruggier
Copy link

@sruggier sruggier commented Oct 7, 2024

This makes it possible to save an offline copy of the tutorial to PDF or paper.

@Darksonn
Copy link
Contributor

Darksonn commented Oct 7, 2024

Thanks. I tried it and it looks ok. However, there's a CI failure due to the "prettier" formatter.

@sruggier sruggier force-pushed the pr/add-print-styles branch from 9d23a80 to 71c5c32 Compare October 7, 2024 21:07
@sruggier
Copy link
Author

sruggier commented Oct 7, 2024

Thanks, it should be fixed now. I also added a bit of detail to the first commit's subject and description.

@sruggier
Copy link
Author

@Darksonn Would you mind re-approving the CI workflow? It should pass now.

@mox692
Copy link
Member

mox692 commented Oct 20, 2024

@sruggier I just re-ran tests. (It seems that some tests are still failing, though)

This makes it much easier to export the documentation to PDF or paper
for offline reading.
The scroll bars are fine in a browser, but not so useful in a PDF file
or on a printed page.
@sruggier sruggier force-pushed the pr/add-print-styles branch from 71c5c32 to 666e62d Compare October 20, 2024 15:48
@sruggier
Copy link
Author

@mox692 Thanks! I've rebased on the master branch, which seems to have a fix for the failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants