Valuable bridge for serde_json::Value #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
force-pushed
the
feature/valuable-json
branch
from
8d44650 to
2ccc2bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides an implementation of
Valuableforserde_json::Value. I'm opening this as a demo of implementingValuableon a complex data type. This is better to be placed inserde_jsoncrate whenvaluablereleased on crates.io. So it's not necessarily to be merged.The reason why it is implemented in
valueablecrate is because an external one requires wrapper type overserde_json::Value. Furthermore, for collection types it may bring in additional allocation.The second part is about the choice between
MappableandStructableforserde_json::Map. UsingMappableis straight-forward but it's lack of key access. CreatingStructDeffrom the map might not be possible because of the slice lifetime ofFields::Named. The is probably we need to consider during the API design.