Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-case Token not applying via Typography Composite Token #3151

Open
keeganedwin opened this issue Sep 20, 2024 · 4 comments
Open

Text-case Token not applying via Typography Composite Token #3151

keeganedwin opened this issue Sep 20, 2024 · 4 comments
Labels
bug Something isn't working needs-responder token type text case typography particle token token type typography composite token type

Comments

@keeganedwin
Copy link
Collaborator

keeganedwin commented Sep 20, 2024

Describe the bug
This bug is ONLY present in this user's token-set and we weren't able to identify it. The user faced the issue when exporting variables and then typography styles with variable references. So applying the typography token is applying all properties except the text-case property. We've removed the variables&styles to see if the text-case would be applied without these factors but it did not. The strange part is that if we copy parts of the tokens (fontFamilies, weights, textCase) into another set to test the different properties and bug as a whole in isolation, it just works.

Expected behavior
The text-case property should just be applied with typography tokens.

Screenshots or Screencasts
The first recording is the user's tokens where the text-case isn't being applied.
User's token-set

This recording is using the user's text-case tokens in a different token-set that just applies the cases as expected
Own token-set

Figma file (optional)
Test file

@six7
Copy link
Collaborator

six7 commented Oct 26, 2024

@keeganedwin i can no longer reproduce on that linked figma file - i think we might have solved this recently. please close if thats the case 🙏

@SamIam4Hyma
Copy link
Collaborator

Closing as it can't be reproduced on behalf of @keeganedwin

@SamIam4Hyma SamIam4Hyma closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Nov 26, 2024
@keeganedwin
Copy link
Collaborator Author

Reopening this ticket as the bug is reproducible in 2.2.3. In the recording I show how applying textCase tokens from the referenced set works, but when referencing the textCase tokens in a typography compositie token, it does not apply the values correctly:
Recording

@keeganedwin keeganedwin reopened this Dec 16, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 👀 Needs review in Tokens Studio for Figma Roadmap Dec 16, 2024
@keeganedwin
Copy link
Collaborator Author

@akshay-gupta7 tested this and all the text-case values except for none seem to work:
Recording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-responder token type text case typography particle token token type typography composite token type
Projects
Status: 👀 Needs review
Development

No branches or pull requests

3 participants