Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'$' sign gets ignored on bulk remap #3081

Open
rbosker opened this issue Aug 16, 2024 · 2 comments
Open

'$' sign gets ignored on bulk remap #3081

rbosker opened this issue Aug 16, 2024 · 2 comments

Comments

@rbosker
Copy link
Collaborator

rbosker commented Aug 16, 2024

Describe the bug
'$' sign gets ignored on bulk remap, which is probably due to the introduction of w3c spec.

To Reproduce
Steps to reproduce the behavior:

  1. Bulk remap a token, where the token name contains a $ sign.
  2. try to remap to another name
  3. the '$' sign gets ignored and remap is not done

Expected behavior
Be able to remap tokens containing a '$' sign

@rbosker rbosker added bug Something isn't working 2.0-followup labels Aug 16, 2024
@rbosker rbosker moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Aug 16, 2024
@six7
Copy link
Collaborator

six7 commented Sep 11, 2024

This is due to regex. Users can escape the $ by typing \$

we should make regex a toggle though

@SamIam4Hyma
Copy link
Collaborator

SamIam4Hyma commented Nov 26, 2024

Sounds like this is a known issue that needs to be added to technical docs and in product messaging. @rbosker what do you think?

We are also blocking the ability to have $ in the token name as it is forbidden so this should be a non-issue in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📤 Ready for dev
Development

No branches or pull requests

3 participants