Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Caps For Dashed Value in Border Composite Token Does Not Work #2975

Open
keeganedwin opened this issue Jul 8, 2024 · 1 comment
Open

Enhancement: Caps For Dashed Value in Border Composite Token Does Not Work #2975

keeganedwin opened this issue Jul 8, 2024 · 1 comment
Assignees
@SamIam4Hyma
Labels
plugin v2 variables, UI, WTCG format, Bitbucket token type border composite token type token value string token value

Comments

@keeganedwin
Copy link
Collaborator

Describe the bug
Using values with caps like Solid or SOLID as a value in the border composite token works as expected, but Dashed or DASHED does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Border composite token
  2. Enter style value as Dashed or DASHED
  3. See error

Expected behavior
Dashed or DASHED should just work as it does with Solid as the value

Screenshots or Screencasts
https://github.com/tokens-studio/figma-plugin/assets/93133012/a5d9117b-90b3-4ad9-96e2-7c7966cf1e8f
@keeganedwin keeganedwin added bug Something isn't working token type border composite token type 2.0-rc9 labels Jul 8, 2024
@SamIam4Hyma SamIam4Hyma added token value plugin v2 variables, UI, WTCG format, Bitbucket token value string labels Jul 24, 2024
@SamIam4Hyma SamIam4Hyma self-assigned this Nov 26, 2024
@rbosker rbosker removed bug Something isn't working 2.0-rc9 labels Dec 9, 2024
@rbosker rbosker changed the title Caps For Dashed Value in Border Composite Token Does Not Work Enhancement: Caps For Dashed Value in Border Composite Token Does Not Work Dec 9, 2024
@rbosker
Copy link
Collaborator

rbosker commented Dec 9, 2024

@keeganedwin solid & dashed work with lowercase (also shown in the preview in the plugin). Solid with a capital doesn't work I believe, but solid is the default value (also if you leave the style blank, the border will populate as solid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamIam4Hyma SamIam4Hyma

Labels
plugin v2 variables, UI, WTCG format, Bitbucket token type border composite token type token value string token value
Projects
Tokens Studio for Figma Roadmap
Status: 📥 Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keeganedwin @rbosker @SamIam4Hyma