Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty line when writing to files (sync providers + local export) #2970

Open
keeganedwin opened this issue Jul 6, 2024 · 1 comment
Open
Labels
json files needs-responder 💡request Community feedback Token Format Legacy and W3C DTCG conversion and JSON

Comments

@keeganedwin
Copy link
Collaborator

keeganedwin commented Jul 6, 2024

Is your feature request related to a problem? Please describe.

Some devs in my team update the tokens directly in the json files. Since we have formatting rules that adds one line at the end of every edited json files, and the same doesn't happen with the tokens pushed from Figma with the plugin. We see this formatting differences in the PR that is in the review to be merged. I just want to turn off auto formatting in the plugin while editing the json and save it.

Describe the solution you'd like
@six7 - What we can do is enable that extra-line at the end, that should be an easy change. The change is likely minimal but all of our users token files will be updated the next time they push. Almost all teams have this rule of an empty line at the end so I'd say lets introduce that.

@keeganedwin keeganedwin added 💡request Community feedback Token Format Legacy and W3C DTCG conversion and JSON json files labels Jul 6, 2024
@six7 six7 changed the title Support For Auto-Formatting in Plugin Add empty line when writing to files (sync providers + local export) Jul 6, 2024
@rlingineni
Copy link

+1 running into this issue with our formatting as well when making PRs from token studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
json files needs-responder 💡request Community feedback Token Format Legacy and W3C DTCG conversion and JSON
Projects
Status: 📥 Triage
Development

No branches or pull requests

3 participants