Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear-Gradient Token Does Not Work With Other Color-spaces (Also When Creating Styles/Variables) #2718

Open
keeganedwin opened this issue May 2, 2024 · 4 comments
Assignees
Labels
bug Something isn't working Figma export Previously create and sync styles variables needs-responder token type color token type gradient Not a type yet but exists in DTCG W3C token value

Comments

@keeganedwin
Copy link
Collaborator

keeganedwin commented May 2, 2024

Describe the bug
Currently when creating color-tokens with linear-gradient values containing color-spaces like: hex-value rgba, hsl, p3, srgb only rgba and hex-values work as a color-spaces, e.g.

WOKRING:
hex - linear-gradient(45deg, #87CEEB 0%, #008000 100%)
rgba - linear-gradient(45deg, rgba(255,255,0) 25%, rgba(255,165,0) 75%).

Since rc8 - linear-gradient(to right, color(display-p3 1 0 0), color(display-p3 0 1 0), color(display-p3 0 0 1))
NOT WORKING:
hsl - linear-gradient(140deg, hsl(34deg 100% 72%) 0%, hsl(29deg 99% 64%))
p3 - linear-gradient(to right, color(display-p3 1 0 0), color(display-p3 0 1 0), color(display-p3 0 0 1))

NOTE:
The plugin is able to detect the colors (displayed in the color swatch) of these values but applying them in Figma does not work as expected. These also don't work when styles are created of them (check screenshot).

To Reproduce
Steps to reproduce the behavior:

  1. Create tokens with the respective values provided above
  2. See error

Expected behavior
Just like with rgba and hex-values, the plugin not only detect but also register the tokens when applied in Figma.

Screenshots or Screencasts
Plugin view:
CleanShot 2024-05-02 at 20 14 54@2x

Figma Styles view:
CleanShot 2024-05-02 at 20 14 36@2x

Figma file (optional)
File

@keeganedwin keeganedwin added bug Something isn't working token types token type gradient Not a type yet but exists in DTCG W3C token type color token value labels May 2, 2024
@keeganedwin keeganedwin changed the title Linear-Gradient Token Does Not Work With Other Color-spaces Linear-Gradient Token Does Not Work With Other Color-spaces (Also When Creating Styles/Variables) May 2, 2024
@UdayHyma
Copy link
Collaborator

UdayHyma commented May 6, 2024

Migrated to Featurebase

@UdayHyma UdayHyma closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap May 6, 2024
@UdayHyma UdayHyma reopened this May 6, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 👀 Needs review in Tokens Studio for Figma Roadmap May 6, 2024
@keeganedwin
Copy link
Collaborator Author

RGB is now working since rc8 and can even be applied as a style.
HSL and p3 however still don't work even as tokens.

@SamIam4Hyma SamIam4Hyma added Figma export Previously create and sync styles variables and removed token types labels Jul 22, 2024
@NuthanHyma
Copy link
Collaborator

@six7 @SamIam4Hyma
This issue still occurs in the RC-9/10

@NuthanHyma
Copy link
Collaborator

Reproducible in V 2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Figma export Previously create and sync styles variables needs-responder token type color token type gradient Not a type yet but exists in DTCG W3C token value
Projects
Status: 👀 Needs review
Development

No branches or pull requests

4 participants