Descriptions of items

[OzumaMR]

The description of everything else than weapon is actually a copy of the description of the weapons.

The error I get in live console:
[ script:qb-core] SCRIPT ERROR: @qb-core/server/player.lua:302: attempt to index a nil value (local 'itemInfo')
[ script:qb-core] > ref (@qb-core/server/player.lua:302)
[ script:qb-core] > GiveStarterItems (@qb-multicharacter/server/main.lua:24)
[ script:qb-core] > handler (@qb-multicharacter/server/main.lua:104)
[ script:qb-core] > query_default (@oxmysql/dist/server/build.js:16108)
[ script:qb-core] > runMicrotasks (:0)
[ script:qb-core] > processTicksAndRejections (node:internal/process/task_queues:96)
[script:qb-multichara] SCRIPT ERROR: error object is not a string

qb-core/server/player.lua:302 refers to the snippets provide in your readme: (itemInfo['created'] = time)
self.Functions.AddItem = function(item, amount, slot, info, created)
local totalWeight = QBCore.Player.GetTotalWeight(self.PlayerData.items)
local itemInfo = QBCore.Shared.Items[item:lower()]
local time = os.time()
if not created then
itemInfo['created'] = time
else
itemInfo['created'] = created
end
-- itemInfo['created'] = time
if itemInfo["type"] == 'item' and info == nil then
info = { quality = 100 }
end
if itemInfo == nil then
TriggerClientEvent('QBCore:Notify', self.PlayerData.source, Lang:t('error.item_not_exist'), 'error')
return
end
local amount = tonumber(amount)
local slot = tonumber(slot) or QBCore.Player.GetFirstSlotByItem(self.PlayerData.items, item)
if itemInfo['type'] == 'weapon' and info == nil then
info = {
serie = tostring(QBCore.Shared.RandomInt(2) .. QBCore.Shared.RandomStr(3) .. QBCore.Shared.RandomInt(1) .. QBCore.Shared.RandomStr(2) .. QBCore.Shared.RandomInt(3) .. QBCore.Shared.RandomStr(4)),
}
end
if (totalWeight + (itemInfo['weight'] * amount)) <= QBCore.Config.Player.MaxWeight then
if (slot and self.PlayerData.items[slot]) and (self.PlayerData.items[slot].name:lower() == item:lower()) and (itemInfo['type'] == 'item' and not itemInfo['unique']) then
self.PlayerData.items[slot].amount = self.PlayerData.items[slot].amount + amount
self.Functions.UpdatePlayerData()
TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'AddItem', 'green', '' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ') got item: [slot:' .. slot .. '], itemname: ' .. self.PlayerData.items[slot].name .. ', added amount: ' .. amount .. ', new total amount: ' .. self.PlayerData.items[slot].amount)
return true
elseif (not itemInfo['unique'] and slot or slot and self.PlayerData.items[slot] == nil) then
self.PlayerData.items[slot] = { name = itemInfo['name'], amount = amount, info = info or '', label = itemInfo['label'], description = itemInfo['description'] or '', weight = itemInfo['weight'], type = itemInfo['type'], unique = itemInfo['unique'], useable = itemInfo['useable'], image = itemInfo['image'], shouldClose = itemInfo['shouldClose'], slot = slot, combinable = itemInfo['combinable'], itemInfo['created'] }
self.Functions.UpdatePlayerData()
TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'AddItem', 'green', '' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ') got item: [slot:' .. slot .. '], itemname: ' .. self.PlayerData.items[slot].name .. ', added amount: ' .. amount .. ', new total amount: ' .. self.PlayerData.items[slot].amount)
return true
elseif (itemInfo['unique']) or (not slot or slot == nil) or (itemInfo['type'] == 'weapon') then
for i = 1, QBConfig.Player.MaxInvSlots, 1 do
if self.PlayerData.items[i] == nil then
self.PlayerData.items[i] = { name = itemInfo['name'], amount = amount, info = info or '', label = itemInfo['label'], description = itemInfo['description'] or '', weight = itemInfo['weight'], type = itemInfo['type'], unique = itemInfo['unique'], useable = itemInfo['useable'], image = itemInfo['image'], shouldClose = itemInfo['shouldClose'], slot = i, combinable = itemInfo['combinable'], created = itemInfo['created'] }
self.Functions.UpdatePlayerData()
TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'AddItem', 'green', '' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ') got item: [slot:' .. i .. '], itemname: ' .. self.PlayerData.items[i].name .. ', added amount: ' .. amount .. ', new total amount: ' .. self.PlayerData.items[i].amount)
return true
end
end
end
else
TriggerClientEvent('QBCore:Notify', self.PlayerData.source, Lang:t('error.too_heavy'), 'error')
end
return false
end

[Qwerty1Verified]

When does this error occur? When you give yourself a valid item? Or when you try to give yourself an invalid item?

[Wendigo23]

It happens when you receive valid items, naturally.

[CrazyDevelopment]

I have the same issue.
Its very odd because only items you purchase from shops are effected, spawning in and obtaining the item from doing jobs ect produce no issue.

A possible solution to this -
Add back the code in the app.js that was removed. Seems to have fixed the item label issue.
around line 640

in reference to the following commit.
0fe1676

[mikeyxb]

I can also confimr this is doing the same for me, existing items in inventory when switching to this inventory get messed up, an items spawned in are fine, items bought from shop are get messed up and will show as the last thing you looked at in the shop

that is before i hover over an item that is fine, i hovered over a boosting laptop in shops and then this for all items in shop

[OGPandaYT]

This issue only happens in the shops has anyone found a fix?

[mikeyxb]

Reverse this commit fixs it 0fe1676

[CrazyDevelopment]

This issue only happens in the shops has anyone found a fix?

I posted how to fix above, Read a bit.

[Jakobe93]

Thanks CrazyDevelopment! Easy fix, no idea why it was removed in the first place

[Qwerty1Verified]

The code was removed because if you read the commit, it is an else statement using null data.