-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
setopt: add page #19641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setopt: add page #19641
Conversation
msaf9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the build failure so that we can begin the actual review process.
|
Hello @gsspdev, could you please fix the build failure and address one of the comments from the review? |
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
znarfm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there will be a page for unsetopt in #19686, I think these suggestions should be applied.
Co-authored-by: Meinard Francisco <[email protected]>
Co-authored-by: Meinard Francisco <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
kbdharun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
Checklist
common,linux,osx,windows,sunos,android, etc.